test: exit sequence sanity tests #25083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
force-pushed
the
exitrace1
branch
from
6aba136 to
e823e93
Compare
|
given that #25061 is landed now, making first attempt in CI to see where we do stand. It passes in Linux locally, but I am interested in other platforms that have variations in thread inetractions. |
gireeshpunathil
removed
the
wip
gireeshpunathil
changed the title
addaleax
reviewed
Jan 25, 2019
addaleax
approved these changes
Jan 27, 2019
Trott
reviewed
Jan 27, 2019
jasnell
approved these changes
Jan 28, 2019
gireeshpunathil
added
the
author ready
Execute many module loads in worker in a loop while exiting from the main thread at arbitrary execution points, and make sure that the workers quiesce without crashing. `worker_threads` are not necessarily the subject of testing, those are used for easy simulation of multi-thread scenarios. Refs: nodejs#25007 PR-URL: nodejs#25083 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
gireeshpunathil
force-pushed
the
exitrace1
branch
from
ae6c952 to
c3fd504
Compare
gireeshpunathil
removed
the
author ready
|
landed as c3fd504 |
3 tasks
targos
pushed a commit
that referenced
this pull request
Jan 29, 2019
Execute many module loads in worker in a loop while exiting from the main thread at arbitrary execution points, and make sure that the workers quiesce without crashing. `worker_threads` are not necessarily the subject of testing, those are used for easy simulation of multi-thread scenarios. Refs: #25007 PR-URL: #25083 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute many module loads in worker in a loop
while exiting from the main thread at arbitrary
execution points, and make sure that the workers
quiesce without crashing.
worker_threadsare not necessarily the subject oftesting, those are used for easy simulation of
multi-thread scenarios.
Refs: #25007
The current code base is not yet ready to conceive this, so please don't land this before #25007 is fully resolved.
Checklist