Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove bad link to irc info #24967

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Dec 11, 2018

Remove a link that no longer appears to point to information about
Node.js IRC channels.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Remove a link that no longer appears to point to information about
Node.js IRC channels.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 11, 2018
@richardlau
Copy link
Member Author

I'm open to replacing the link if someone has a suitable alternative. The current link is actually blocked at work for being pornographic (and a colleague has confirmed that it's not an inaccurate categorization). WHOIS suggests the domain was recently created/updated (perhaps the old registration expired?): https://whois.icann.org/en/lookup?name=nodeirc.info

Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this link is definitely not something that should be in our readme

@devsnek devsnek added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 11, 2018
@devsnek
Copy link
Member

devsnek commented Dec 11, 2018

Node Collaborators, 👍 here to fast-track

@watilde
Copy link
Member

watilde commented Dec 11, 2018

As alternative, we can consider to using webchat:

which is used in website: https://nodejs.org/en/get-involved/

@devsnek
Copy link
Member

devsnek commented Dec 11, 2018

@watilde the current link is https://webchat.freenode.net?channels=node.js&uio=d4

@Trott
Copy link
Member

Trott commented Dec 11, 2018

Landed in 8c290fd

@Trott Trott closed this Dec 11, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 11, 2018
Remove a link that no longer appears to point to information about
Node.js IRC channels.

PR-URL: nodejs#24967
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
Remove a link that no longer appears to point to information about
Node.js IRC channels.

PR-URL: #24967
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Remove a link that no longer appears to point to information about
Node.js IRC channels.

PR-URL: nodejs#24967
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Remove a link that no longer appears to point to information about
Node.js IRC channels.

PR-URL: #24967
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Remove a link that no longer appears to point to information about
Node.js IRC channels.

PR-URL: #24967
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Remove a link that no longer appears to point to information about
Node.js IRC channels.

PR-URL: #24967
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants