test: remove magic numbers in test-gc-http-client-onerror #24943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stress test on master (with Stress test on this PR with same parameters: |
|
Relevant failure: https://ci.nodejs.org/job/node-test-commit-linux/23914/nodes=centos6-64-gcc6/console If I had to guess, it's because of the removal of the early return in getall(). |
Yeah, there's a few of those. Not sure how to re-implement an early return without restoring some kind of magic number but I'll think about it.... |
|
@Trott it should be sufficient to add another variable (e.g., |
Trott
force-pushed
the
fix-23089
branch
2 times, most recently
from
502e7a7 to
aeb2138
Compare
Trott
force-pushed
the
fix-23089
branch
2 times, most recently
from
92b8899 to
011027a
Compare
Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: nodejs#23089
|
Worked out the puzzle. This works now. Could use some reviews! |
|
Needs a review or two. /ping @nodejs/testing |
|
Bump. |
cjihrig
approved these changes
Dec 16, 2018
Trott
added
the
author ready
|
Landed in 47ecf20 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 17, 2018
Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: nodejs#23089 PR-URL: nodejs#24943 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: #23089 PR-URL: #24943 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: #23089 PR-URL: #24943 Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 25, 2018
Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: #23089 PR-URL: #24943 Reviewed-By: Colin Ihrig <[email protected]>
Merged
This was referenced Dec 26, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: nodejs#23089 PR-URL: nodejs#24943 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove magic numbers 500 and 10 from the test. Instead, detect when GC
has started and stop sending requests at that point.
On my laptop, this results in 68 or 72 requests per run instead of 500.
Fixes: #23089
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes