[v8.x] http2: fix sequence of error/close events #24789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v6.x
http2
This was referenced Dec 2, 2018
lpinca
approved these changes
Dec 3, 2018
|
Could we get a review from @nodejs/http2? |
|
I think the original commit should be cherry-picked: e03bcb1. |
|
is cherry-picking something I should do in this PR or is this done during integration on v8.x branch? |
trivikr
approved these changes
Dec 8, 2018
BethGriggs
pushed a commit
that referenced
this pull request
Dec 11, 2018
Correct sequence of emitting `error` and `close` events for a `Http2Stream`. PR-URL: #24789 Refs: #22850 Refs: #24685 Fixes: #24559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs
added a commit
that referenced
this pull request
Dec 11, 2018
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 18, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Dec 18, 2018
This was referenced Dec 18, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Notable changes:
* **assert**:
- revert breaking change (Ruben Bridgewater)
[nodejs#24786](nodejs#24786)
* **http2**:
- fix sequence of error/close events (Gerhard Stoebich)
[nodejs#24789](nodejs#24789)
PR-URL: nodejs#24832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct sequence of emitting
errorandcloseevents for aHttp2Stream.Refs: #22850
Refs: #24685
Fixes: #24559
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes