lib: fix comment nits in bootstrap\loaders.js #24641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
the
lib / src
|
As only comments are changed, it seems CI-lite suffices. Let me know if we need full CI. |
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
lpinca
approved these changes
Nov 26, 2018
fhinkel
approved these changes
Nov 27, 2018
|
Landed in 1db808c |
vsemozhetbyt
added a commit
that referenced
this pull request
Nov 27, 2018
PR-URL: #24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2018
PR-URL: #24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
2 tasks
GaryGSC
pushed a commit
to GaryGSC/node
that referenced
this pull request
Nov 8, 2019
Backport-PR-URL: nodejs#30338 PR-URL: nodejs#24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> (cherry picked from commit 1db808c)
BethGriggs
pushed a commit
that referenced
this pull request
Nov 22, 2019
Backport-PR-URL: #30338 PR-URL: #24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Backport-PR-URL: #30338 PR-URL: #24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes