test: create files and directories in the tmp directory instead of fixture directory #24077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhSiddhu
changed the title
Trott
reviewed
Nov 9, 2018
| const existingFile = fixtures.path('exit.js'); | ||
| const existingFile2 = fixtures.path('a.js'); | ||
| const existingDir = tmpdir.path; | ||
|
|
Trott
reviewed
Nov 9, 2018
| const nonexistentDir = path.join(tmpdir.path, 'non-existent', 'foo', 'bar'); | ||
| const existingFile = path.join(tmpdir.path, 'existingFile.js'); | ||
| const existingFile2 = path.join(tmpdir.path, 'existingFile2.js'); | ||
| const existingDir = path.join(tmpdir.path, 'dir'); | ||
| const existingDir2 = fixtures.path('keys'); |
There was a problem hiding this comment.
Any reason you didn't move existingDir2 to something under tmpdir as well?
Trott
approved these changes
Nov 9, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18448/ |
jasnell
approved these changes
Nov 10, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18518/ |
|
Resume Build doesn't rebase against latest master I don't think, so this is getting bitten by a flaky that's been fixed. I think. New full Ci... |
|
Landed in 1e0005e. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 11, 2018
PR-URL: nodejs#24077 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24077 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24077 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 14, 2018
PR-URL: #24077 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
PR-URL: #24077 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes