-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add link to VSCode config in testing #24012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That config repo was transferred into the org without opening an issue in the admin repo to discuss. (That process is not easy to surface if you don't know where it is, so I understand why it was missed!)
The config repo lacks things that might have been insisted upon during that process. For example, there is no Code of Conduct and no LICENSE file. 😱 I don't know if transferring it out is the answer and then opening the issue in the admin repo? @nodejs/tsc @nodejs/community-committee
I'm not sure we want to add IDE-specific configurations into BUILDING.md. (I'm also not sure we don't. Curious what others think.)
Updates about node-vscode-config:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I love VSCode and use it daily, I'd much prefer moving this kind of stuff into a separate guide that can detail the use of multiple tools.
👍
Personally I'd like to see the guide shrink... I feel that as the top level guide it's too verbose. So I'm -1 on adding more specific cases to it, including IDE specific instructions, unless that can help to un-verbose the guide. That said, IMHO this would be useful to have in a separate guide, referred to from the main guide. |
@jasnell Steps taken:
|
Since I ran out of time, I forgot to show the VSCode launch configs being used in my NodeConfEU talk today. Can we push this code so that new contributors don't get stuck finding out the VSCode launch config while contributing to Node? |
At the risk of getting too picky here, should we refrain from having developer stuff in the build doc and instead put that in CONTRIBUTING.md or something else that is aimed at developers working on Node.js core? BUILDING.md has a broader audience than that IMO. |
(Granted, there are probably things in BUILDING.md already that, based on that criteria, should be moved out, like coverage generation.) |
Added tsc-agenda label, for discussions related to following questions:
Follow up required on PRs:
|
Removed tsc-agenda label as we agreed on name |
7c5dc9a
to
fcd82e6
Compare
Refs: https://github.com/orgs/nodejs/teams/collaborators/discussions/58 This config will help contributors to run/debug tests on VSCode
fcd82e6
to
fcfbbc1
Compare
Refs: https://github.com/orgs/nodejs/teams/collaborators/discussions/58 This config will help contributors to run/debug tests on VSCode PR-URL: #24012 Reviewed-By: James M Snell <[email protected]>
Landed in e55d653 |
Refs: https://github.com/orgs/nodejs/teams/collaborators/discussions/58 This config will help contributors to run/debug tests on VSCode PR-URL: #24012 Reviewed-By: James M Snell <[email protected]>
Refs: https://github.com/orgs/nodejs/teams/collaborators/discussions/58 This config will help contributors to run/debug tests on VSCode PR-URL: #24012 Reviewed-By: James M Snell <[email protected]>
Refs: https://github.com/orgs/nodejs/teams/collaborators/discussions/58 This config will help contributors to run/debug tests on VSCode PR-URL: #24012 Reviewed-By: James M Snell <[email protected]>
Refs: https://github.com/orgs/nodejs/teams/collaborators/discussions/58
This config will help contributors to run/debug tests on VSCode
Checklist