Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note about removeListener order #23762

Closed
wants to merge 1 commit into from
Closed

doc: add note about removeListener order #23762

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 19, 2018

Fixes: #21635

Checklist

@jasnell jasnell added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 19, 2018
@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1300/pipeline

@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2018

Please 👍 to fast-track

vsemozhetbyt
vsemozhetbyt reviewed Oct 19, 2018
View reviewed changes
doc/api/events.md Outdated Show resolved Hide resolved
vsemozhetbyt
vsemozhetbyt reviewed Oct 19, 2018
View reviewed changes
doc/api/events.md Outdated Show resolved Hide resolved
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2018
@jasnell jasnell force-pushed the events-removelistener-order branch from c9cbf95 to 2f8098d Compare October 23, 2018 20:03
@jasnell
Copy link
Member Author

jasnell commented Oct 23, 2018 •
edited
Loading

Landed in 2f8098d

@jasnell jasnell closed this Oct 23, 2018
@jasnell jasnell reopened this Oct 23, 2018
@jasnell
Copy link
Member Author

jasnell commented Oct 23, 2018

Sorry... heh... mixed up the PRs lol

jasnell added a commit that referenced this pull request Oct 23, 2018
@jasnell
doc: add note about removeListener order
b049d55 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Oct 23, 2018

Landed in b049d55

@jasnell jasnell closed this Oct 23, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
@jasnell @targos
doc: add note about removeListener order
84fdb1c 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@jasnell @MylesBorins
doc: add note about removeListener order
c251d40 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@jasnell @MylesBorins
doc: add note about removeListener order
9982c09 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: add note about removeListener order
e5f75cf 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: add note about removeListener order
8990e32 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jasnell @MylesBorins
doc: add note about removeListener order
98fc848 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@mmarchini mmarchini mmarchini approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasnell @nodejs-github-bot @addaleax @lpinca @mmarchini @vsemozhetbyt @trivikr @MylesBorins