Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls_wrap: add default initializer #23567

Closed
wants to merge 1 commit into from
Closed

tls_wrap: add default initializer #23567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/tls_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,7 @@ TLSWrap::TLSWrap(Environment* env,
AsyncWrap::PROVIDER_TLSWRAP),
SSLWrap<TLSWrap>(env, sc, kind),
StreamBase(env),
sc_(sc),
write_size_(0),
started_(false),
established_(false),
shutdown_(false),
cycle_depth_(0),
eof_(false) {
sc_(sc) {
MakeWeak();

// sc comes from an Unwrap. Make sure it was assigned.
Expand Down
12 changes: 6 additions & 6 deletions src/tls_wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,19 +149,19 @@ class TLSWrap : public AsyncWrap,
BIO* enc_in_ = nullptr;
BIO* enc_out_ = nullptr;
std::vector<uv_buf_t> pending_cleartext_input_;
size_t write_size_;
size_t write_size_ = 0;
WriteWrap* current_write_ = nullptr;
WriteWrap* current_empty_write_ = nullptr;
bool write_callback_scheduled_ = false;
bool started_;
bool established_;
bool shutdown_;
bool started_ = false;
bool established_ = false;
bool shutdown_ = false;
std::string error_;
int cycle_depth_;
int cycle_depth_ = 0;

// If true - delivered EOF to the js-land, either after `close_notify`, or
// after the `UV_EOF` on socket.
bool eof_;
bool eof_ = false;

private:
static void GetWriteQueueSize(
Expand Down