Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,lib: make process.binding('config') internal #23400

Closed
wants to merge 1 commit into from
Closed

src,lib: make process.binding('config') internal #23400

wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Oct 10, 2018 •
edited
Loading

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
    - [ ] documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 10, 2018
@shisama shisama force-pushed the config-binding branch 3 times, most recently from 5a2a9d6 to 1f0b70d Compare October 15, 2018 00:47
@jasnell jasnell mentioned this pull request Oct 15, 2018
Closed
33 tasks
@shisama shisama force-pushed the config-binding branch 4 times, most recently from a419245 to 58c315c Compare October 18, 2018 09:20
@shisama shisama changed the title [WIP] config: make process.binding('config') internal [WIP] make process.binding('config') internal Oct 18, 2018
@shisama shisama changed the title [WIP] make process.binding('config') internal [WIP] src,lib: make process.binding('config') internal Oct 18, 2018
@shisama shisama force-pushed the config-binding branch 18 times, most recently from e33577b to 2923d07 Compare October 25, 2018 14:22
@gireeshpunathil
Copy link
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-commit/23812/

@shisama
Copy link
Contributor Author

shisama commented Nov 30, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19081/

@gireeshpunathil
Copy link
Member

@shisama - what a coincidence!!! looks like we fired two CIs almost at the same time.

@shisama
Copy link
Contributor Author

shisama commented Dec 3, 2018

Resume CI: https://ci.nodejs.org/job/node-test-commit/23889/

@shisama
Copy link
Contributor Author

shisama commented Dec 3, 2018 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19156/

@joyeecheung joyeecheung mentioned this pull request Dec 5, 2018
Closed
@shisama
Copy link
Contributor Author

shisama commented Dec 5, 2018

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/19219/

@Trott
Copy link
Member

Trott commented Dec 5, 2018

Landed in 63b0655

@Trott Trott closed this Dec 5, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2018
@Trott
src,lib: make process.binding('config') internal
63b0655 
PR-URL: nodejs#23400
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 6, 2018
@BridgeAR
src,lib: make process.binding('config') internal
bdd4021 
PR-URL: #23400
Refs: #22160
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
Merged
4 tasks
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@BridgeAR
src,lib: make process.binding('config') internal
88a5449 
PR-URL: #23400
Refs: #22160
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@BridgeAR
src,lib: make process.binding('config') internal
f323dbe 
PR-URL: #23400
Refs: #22160
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 11, 2019
@joyeecheung
src,lib: make process.binding('config') internal
b6afa46 
PR-URL: nodejs#23400
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@addaleax
src,lib: make process.binding('config') internal
7480864 
PR-URL: #23400
Refs: #22160
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

Backport-PR-URL: #25446
Reviewed-By: Anna Henningsen <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
src,lib: make process.binding('config') internal
837bfaa 
PR-URL: nodejs#23400
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@BridgeAR
src,lib: make process.binding('config') internal
dc7c05d 
PR-URL: nodejs#23400
Refs: nodejs#22160
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

Backport-PR-URL: nodejs#25446
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shisama @Trott @gireeshpunathil @cjihrig @joyeecheung @trivikr @BethGriggs @nodejs-github-bot