-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: simplify governance info in README intro #23320
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary wordiness in the governance sentence. It appears very early in the README so it should be short and clear. This also removes an instance of passive voice.
cjihrig
approved these changes
Oct 7, 2018
vsemozhetbyt
approved these changes
Oct 8, 2018
vsemozhetbyt
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 8, 2018
jasnell
approved these changes
Oct 8, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 9, 2018
Remove unnecessary wordiness in the governance sentence. It appears very early in the README so it should be short and clear. This also removes an instance of passive voice. PR-URL: nodejs#23320 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in eddfa2c |
targos
pushed a commit
that referenced
this pull request
Oct 10, 2018
Remove unnecessary wordiness in the governance sentence. It appears very early in the README so it should be short and clear. This also removes an instance of passive voice. PR-URL: #23320 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 10, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Remove unnecessary wordiness in the governance sentence. It appears very early in the README so it should be short and clear. This also removes an instance of passive voice. PR-URL: #23320 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary wordiness in the governance sentence. It appears very
early in the README so it should be short and clear. This also removes
an instance of passive voice.
Checklist