-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: use default parameters for UVException()
#23176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually surprised that this is exported..is there any modules actually using this? I couldn't find anything when I did a quick search on GitHub.
Oh nvm, just saw #23175 |
@joyeecheung I’m not sure, but of the many, many things in |
@addaleax I can see what you mean...it probably makes sense to add something like this to N-API? (Not sure about how comfortable we are with exposing libuv related stuff there but we do have |
I guess that would be part of the larger libuv/N-API discussion (libuv/libuv#1931) … I’m still personally inclined to let libuv be and mark a subset of it as ABI-stable, which would mean that we don’t need to do anything ;) |
Landed in 51f0060. |
PR-URL: #23176 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #23176 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
(dont-land-on-v10.x because of the ABI change.)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes