Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] deps: cherry-pick 9a23bdd from upstream V8 #22910

Closed
wants to merge 1 commit into from
Closed

[v10.x backport] deps: cherry-pick 9a23bdd from upstream V8 #22910

wants to merge 1 commit into from

Conversation

Drieger
Copy link
Contributor

@Drieger Drieger commented Sep 17, 2018

Previously we were getting the code object from the stack, so printed incorrect
position details for interpreted frames.

BUG=v8:7916

Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
Reviewed-on: https://chromium-review.googlesource.com/1126313
Reviewed-by: Toon Verwaest [email protected]
Commit-Queue: Ross McIlroy [email protected]
Cr-Commit-Position: refs/heads/master@{#54253}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added v10.x v8 engine Issues and PRs related to the V8 dependency. labels Sep 17, 2018
@Drieger Drieger mentioned this pull request Sep 17, 2018
Closed
@Drieger Drieger force-pushed the backport-22338-to-v10.x branch 3 times, most recently from 7876bc6 to b76f5f7 Compare September 17, 2018 18:05
mmarchini
mmarchini approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the commit message should follow the format described here.

@Drieger Drieger changed the title [v10.x backport ] Fix Isolate::PrintCurrentStackTrace for interpreted frames [v10.x backport ] deps: cherry-pick 9a23bdd from upstream V8 Sep 17, 2018
@Drieger Drieger changed the title [v10.x backport ] deps: cherry-pick 9a23bdd from upstream V8 [v10.x backport] deps: cherry-pick 9a23bdd from upstream V8 Sep 17, 2018
@Drieger Drieger force-pushed the backport-22338-to-v10.x branch from b76f5f7 to 66bf218 Compare September 17, 2018 19:11
@Drieger
Copy link
Contributor Author

Drieger commented Sep 17, 2018

@mmarchini Updated commit message to match the correct format.

@Drieger Drieger force-pushed the backport-22338-to-v10.x branch from 66bf218 to bf9f693 Compare September 17, 2018 19:27
@mmarchini
Copy link
Contributor

mmarchini commented Sep 17, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/17260/ ✅
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1694/ ✅

richardlau
richardlau previously requested changes Sep 17, 2018
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For v10.x v8_embedder_string in common.gypi should be incremented instead of the V8 patch level: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md

@Drieger
deps: cherry-pick 9a23bdd from upstream V8
c0aa2d0 
Original commit message:

    [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames

    Previously we were getting the code object from the stack, so printed incorrect
    position details for interpreted frames.

    BUG=v8:7916

    Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
    Reviewed-on: https://chromium-review.googlesource.com/1126313
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Ross McIlroy <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#54253}

Refs: nodejs#21988
@Drieger Drieger force-pushed the backport-22338-to-v10.x branch from bf9f693 to c0aa2d0 Compare September 18, 2018 10:42
@Drieger
Copy link
Contributor Author

Drieger commented Sep 18, 2018

@richardlau Updated v8_embedder_string and removed modification on V8 patch level.

@targos
Copy link
Member

targos commented Sep 18, 2018

Refs: v8/v8@9a23bdd

@misterdjules misterdjules mentioned this pull request Sep 18, 2018
Merged
@targos
Copy link
Member

targos commented Sep 19, 2018

Landed in 0f99b8d4bd693c859ef5a954c5b0efdd4c1c95a8

@targos targos closed this Sep 19, 2018
targos pushed a commit that referenced this pull request Sep 19, 2018
@Drieger @targos
deps: cherry-pick 9a23bdd from upstream V8
f297866 
Original commit message:

    [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames

    Previously we were getting the code object from the stack, so printed incorrect
    position details for interpreted frames.

    BUG=v8:7916

    Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
    Reviewed-on: https://chromium-review.googlesource.com/1126313
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Ross McIlroy <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#54253}

Refs: v8/v8@9a23bdd
Refs: #21988
PR-URL: #22910
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Sep 20, 2018
@Drieger @targos
deps: cherry-pick 9a23bdd from upstream V8
5660759 
Original commit message:

    [Isolate] Fix Isolate::PrintCurrentStackTrace for interpreted frames

    Previously we were getting the code object from the stack, so printed incorrect
    position details for interpreted frames.

    BUG=v8:7916

    Change-Id: I2f87584117d88b7db3f3b9bdbfe793c4d3e33fe9
    Reviewed-on: https://chromium-review.googlesource.com/1126313
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Ross McIlroy <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#54253}

Refs: v8/v8@9a23bdd
Refs: #21988
PR-URL: #22910
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmarchini mmarchini mmarchini approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau left review comments

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Drieger @mmarchini @targos @richardlau @nodejs-github-bot