Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick 09bca09 from upstream V8 #22068

Closed
wants to merge 2 commits into from
Closed

deps: cherry-pick 09bca09 from upstream V8 #22068

wants to merge 2 commits into from

Conversation

mmarchini
Copy link
Contributor

@mmarchini mmarchini commented Aug 1, 2018 •
edited
Loading

Original commit message:

[postmortem] add ScopeInfo and Context types

The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).

[email protected], [email protected]

Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#54768}

Refs: v8/v8@09bca09

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Matheus Marchini added 2 commits August 1, 2018 15:09
deps: cherry-pick 09bca09 from upstream V8
b631495 
Original commit message:

    [postmortem] add ScopeInfo and Context types

    The metadata introduced in this patch will be useful for postmortem
    tools to inspect Contexts and ScopeInfos (see
    nodejs/llnode#211).

    [email protected], [email protected]

    Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
    Reviewed-on: https://chromium-review.googlesource.com/1153858
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#54768}

Refs: v8/v8@09bca09
fixup! deps: cherry-pick 09bca09 from upstream V8
c70098b
@nodejs-github-bot
Copy link
Collaborator

@mmarchini build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/394/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency. labels Aug 1, 2018
@mmarchini mmarchini changed the title V8 09bca095 deps: cherry-pick 09bca09 from upstream V8 Aug 1, 2018
@mmarchini
Copy link
Contributor Author

mmarchini commented Aug 1, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/16128/ ❌
CI: https://ci.nodejs.org/job/node-test-pull-request/16152/ ✅
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1561/ ✅

@jasnell
Copy link
Member

jasnell commented Aug 1, 2018

Can you please include the original commit message in the PR description above?

@mmarchini
Copy link
Contributor Author

@jasnell done!

@mmarchini
Copy link
Contributor Author

Landed in a4c1cf5

@mmarchini mmarchini closed this Aug 6, 2018
mmarchini pushed a commit that referenced this pull request Aug 6, 2018
deps: cherry-pick 09bca09 from upstream V8
a4c1cf5 
Original commit message:

    [postmortem] add ScopeInfo and Context types

    The metadata introduced in this patch will be useful for postmortem
    tools to inspect Contexts and ScopeInfos (see
    nodejs/llnode#211).

    [email protected], [email protected]

    Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
    Reviewed-on: https://chromium-review.googlesource.com/1153858
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#54768}

Refs: v8/v8@09bca09

PR-URL: #22068
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos
Copy link
Member

targos commented Aug 6, 2018

Should land with or after #21668 on v10.x-staging

@targos
Copy link
Member

targos commented Aug 6, 2018

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

@mmarchini
Copy link
Contributor Author

Should land with or after #21668 on v10.x-staging

After, since this wasn't included in V8 6.8. Btw, I checked and this lands cleanly on v10.x-staging (at least for now, let's see after #21668 lands)

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

That's odd, in the PR GitHub shows the embedder string being bumped. I also don't know how we can prevent it in the future.

@targos
Copy link
Member

targos commented Aug 6, 2018

Also, the embedder string bump was lost when this landed. Not your fault @mmarchini, I don't know how we can prevent it.

That's odd, in the PR GitHub shows the embedder string being bumped. I also don't know how we can prevent it in the future.

It happens sometimes, when master already had the bump from another PR. Instead of creating a conflict, git just makes the change a no-op.

@mmarchini
Copy link
Contributor Author

Marked as dont-land-on-v8.x since SCOPE_INFO_TYPE, FIRST_CONTEXT_TYPE and LAST_CONTEXT_TYPE don't exist on V8 6.2.

targos pushed a commit that referenced this pull request Aug 11, 2018
@targos
deps: cherry-pick 09bca09 from upstream V8
e1dcb79 
Original commit message:

    [postmortem] add ScopeInfo and Context types

    The metadata introduced in this patch will be useful for postmortem
    tools to inspect Contexts and ScopeInfos (see
    nodejs/llnode#211).

    [email protected], [email protected]

    Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
    Reviewed-on: https://chromium-review.googlesource.com/1153858
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#54768}

Refs: v8/v8@09bca09

PR-URL: #22068
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
targos pushed a commit to targos/node that referenced this pull request Sep 7, 2018
@targos
deps: cherry-pick 09bca09 from upstream V8
30b0796 
Original commit message:

    [postmortem] add ScopeInfo and Context types

    The metadata introduced in this patch will be useful for postmortem
    tools to inspect Contexts and ScopeInfos (see
    nodejs/llnode#211).

    [email protected], [email protected]

    Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
    Reviewed-on: https://chromium-review.googlesource.com/1153858
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#54768}

Refs: v8/v8@09bca09

PR-URL: nodejs#22068
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Sep 7, 2018
@targos
deps: cherry-pick 09bca09 from upstream V8
127e703 
Original commit message:

    [postmortem] add ScopeInfo and Context types

    The metadata introduced in this patch will be useful for postmortem
    tools to inspect Contexts and ScopeInfos (see
    nodejs/llnode#211).

    [email protected], [email protected]

    Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
    Reviewed-on: https://chromium-review.googlesource.com/1153858
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#54768}

Refs: v8/v8@09bca09

PR-URL: nodejs#22068
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmarchini @nodejs-github-bot @jasnell @targos @BridgeAR