doc: replace deprecated CI job #21938
Conversation
`node-test-pull-request-lite` CI job is deprecated now and https://ci.nodejs.org/job/node-test-pull-request-lite/ has this note: "DEPRECATED: please use the node-test-pull-request-lite-pipeline job".
vsemozhetbyt
added
the
meta
|
Not sure if this should be approved by the TSC or any other WG. Please, cc or label as seems appropriate. |
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
| @@ -213,7 +213,7 @@ needs to be pointed out separately during the onboarding. | |||
| * Optionally, include your personal pronouns. | |||
| * Label your pull request with the `doc` and `notable-change` labels. | |||
| * Run CI on the PR. Because the PR does not affect any code, use the | |||
| `node-test-pull-request-lite` CI task. Alternatively, use the usual | |||
| `node-test-pull-request-lite-pipeline` CI task. Alternatively, use the usual | |||
| `node-test-pull-request` CI task and cancel it after the linter and one other | |||
| subtask have passed. | |||
There was a problem hiding this comment.
Maybe one for @nodejs/build to comment on, but my own experience with Jenkins is that cancelling jobs can sometimes leave workspaces in a bad state (usually manifesting in git checkout errors on subsequent runs) depending on where the job was at at the time it was cancelled so I'm not generally in favour of encouraging the cancellation of jobs.
There was a problem hiding this comment.
From my personal experience, a lot of git checkout errors / infra failures in general with ci.nodejs.org can be linked back to issues with the machine itself, not usually due to cancelling jobs early. Also, you could say there's a benefit from new collaborators practicing how to launch node-test-pull-request jobs. I'd rather folks let the build go all the way through and finish, but I don't think they're "breaking our infra" by cancelling it early.
There was a problem hiding this comment.
I'd prefer that cancelling jobs is not encouraged at all, I've seen a lot of failures because of it. It may not be the most frequent issue but it happens.
At least two cases are know: 1) Abort during a git operation will leave behind a lock file that will make all following jobs on that machine fail; 2) Visual Studio will not stop running immediately after the job is aborted, locking some files and making git clean fail for some time/jobs (happens easily when there are queued jobs). Note that Jenkins does not offer us any reliable way of running anything between jobs, so fixing this is not straightforward.
(To be clear, I'm also not blocking this PR, but would be in favor of deleting the sentence starting at "Alternatively".)
There was a problem hiding this comment.
I will make a new PR after landing to draw more attention to this change.
|
cc @nodejs/automation It seems the |
|
Landed in c75f36f |
`node-test-pull-request-lite` CI job is deprecated now and https://ci.nodejs.org/job/node-test-pull-request-lite/ has this note: "DEPRECATED: please use the node-test-pull-request-lite-pipeline job". PR-URL: #21938 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: João Reis <[email protected]>
`node-test-pull-request-lite` CI job is deprecated now and https://ci.nodejs.org/job/node-test-pull-request-lite/ has this note: "DEPRECATED: please use the node-test-pull-request-lite-pipeline job". PR-URL: #21938 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: João Reis <[email protected]>
Refs: #21938 (comment) and discussion below the comment. PR-URL: #21977 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Refs: #21938 (comment) and discussion below the comment. PR-URL: #21977 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesnode-test-pull-request-liteCI job is deprecated now and https://ci.nodejs.org/job/node-test-pull-request-lite/ has this note: "DEPRECATED: please use the node-test-pull-request-lite-pipeline job".