Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fixup docs and run known_issues by default #21910

Closed
wants to merge 1 commit into from
Closed

tools: fixup docs and run known_issues by default #21910

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

  • Updates test/README.md with new suites
  • Fixes some outdated IGNORED_SUITES listings
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/322/pipeline

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jul 20, 2018
@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 20, 2018
Trott
Trott reviewed Jul 20, 2018
View reviewed changes
tools/test.py Outdated
@@ -1554,9 +1554,8 @@ def PrintCrashed(code):
'gc',
'internet',
'pummel',
'test-known-issues',
'known_issues',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised known_issues is in the ignore set. Any objection to removing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(probably) fine with removing it, but might be best to do in a separate PR for visibility.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if this lands then won't we stop running known_issues until the subsequent PR to remove it from this list lands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau Ah, true -- I'll remove known_issues from the list in this PR :)

Trott
Trott approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I think we should be running known_issues, no?

@maclover7
Copy link
Contributor Author

Will land this as-is, and open up a separate PR re: test/known_issues

@maclover7
Copy link
Contributor Author

CI before landing: https://ci.nodejs.org/job/node-test-pull-request/16006/

@Trott
Copy link
Member

Trott commented Jul 25, 2018

Nit: fixup -> fix up in commit message to keep the verb as the first word.

@maclover7 maclover7 changed the title doc,tools: fixup documentation tools: fixup docs and run known_issues by default Jul 26, 2018
@maclover7
tools: fix docs and run known_issues by default
e039bde 
- Updates `test/README.md` with new suites
- Fixes some outdated `IGNORED_SUITES` listings
- Allows for `test/known_issues` suite to be run by default
@maclover7
Copy link
Contributor Author

Updated @richardlau @Trott, PTAL

richardlau
richardlau approved these changes Jul 26, 2018
View reviewed changes
test/README.md
@@ -31,7 +35,7 @@ GitHub with the `autocrlf` git config flag set to true.
|sequential |Yes |Various tests that are run sequentially.|
|testpy | |Test configuration utility used by various test suites.|
|tick-processor |No |Tests for the V8 tick processor integration. The tests are for the logic in ```lib/internal/v8_prof_processor.js``` and ```lib/internal/v8_prof_polyfill.js```. The tests confirm that the profile processor packages the correct set of scripts from V8 and introduces the correct platform specific logic.|
|timers |No |Tests for [timing utilities](https://nodejs.org/api/timers.html) (```setTimeout``` and ```setInterval```).|
|v8-updates |No |Tests for V8 performance integration.|

_When a new test directory is added, make sure to update the `CI_JS_SUITES`
variable in the `Makefile` and the `js_test_suites` variable in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bottom note can probably be removed too as it looks like both CI_JS_SUITES and js_test_suites are default rather than a list of test directories. This can be done in another PR if you'd rather just land this PR as-is.

@maclover7
Copy link
Contributor Author

Landed in b1b2f7c, thank you for the reviews!

@maclover7 maclover7 closed this Jul 27, 2018
@maclover7 maclover7 deleted the jm-test-fixup branch July 27, 2018 00:49
maclover7 added a commit that referenced this pull request Jul 27, 2018
@maclover7
tools: fix docs and run known_issues by default
b1b2f7c 
- Updates `test/README.md` with new suites
- Fixes some outdated `IGNORED_SUITES` listings
- Allows for `test/known_issues` suite to be run by default

PR-URL: #21910
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 31, 2018
@targos
Copy link
Member

targos commented Jul 31, 2018

Depends on #22039 to land on v10.x-staging

@targos targos mentioned this pull request Jul 31, 2018
Closed
3 tasks
targos pushed a commit that referenced this pull request Aug 2, 2018
@maclover7 @targos
tools: fix docs and run known_issues by default
7a7c194 
- Updates `test/README.md` with new suites
- Fixes some outdated `IGNORED_SUITES` listings
- Allows for `test/known_issues` suite to be run by default

PR-URL: #21910
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@sam-github sam-github mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@richardlau richardlau richardlau approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@lance lance lance approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maclover7 @nodejs-github-bot @Trott @targos @lance @jasnell @richardlau @vsemozhetbyt