test: refactor cluster-net-listen-relative-path #21863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor test-cluster-net-listen-relative-path: * Use arrow funcitons for callbacks. * Move skip-test code closer to start of file. * Use assert.ok() where appropriate. * Capitalize and punctuate comments.
trivikr
approved these changes
Jul 18, 2018
addaleax
approved these changes
Jul 18, 2018
trivikr
added
the
author ready
jasnell
approved these changes
Jul 18, 2018
maclover7
approved these changes
Jul 18, 2018
lpinca
approved these changes
Jul 19, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 20, 2018
Refactor test-cluster-net-listen-relative-path: * Use arrow funcitons for callbacks. * Move skip-test code closer to start of file. * Use assert.ok() where appropriate. * Capitalize and punctuate comments. PR-URL: nodejs#21863 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in c3f8dd6 |
targos
pushed a commit
that referenced
this pull request
Jul 20, 2018
Refactor test-cluster-net-listen-relative-path: * Use arrow funcitons for callbacks. * Move skip-test code closer to start of file. * Use assert.ok() where appropriate. * Capitalize and punctuate comments. PR-URL: #21863 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor test-cluster-net-listen-relative-path:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes