fs: improve fs.watch ENOSPC error message #21846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
errors
addaleax
force-pushed
the
fs-watch-enospc
branch
from
179598d to
b2b052c
Compare
|
The test probably needs some per-platform tweaking, so: |
addaleax
force-pushed
the
fs-watch-enospc
branch
from
b2b052c to
fd21126
Compare
jasnell
approved these changes
Jul 18, 2018
lpinca
approved these changes
Jul 18, 2018
| } | ||
|
|
||
| setTimeout(() => { | ||
| if (!finished && processes.length < 200) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
addaleax
force-pushed
the
fs-watch-enospc
branch
2 times, most recently
from
6f4bd38 to
b156539
Compare
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16123/ Might be good to get another @nodejs/tsc review – this error comes with a code already, so I don’t think this has to be semver-major. |
targos
approved these changes
Aug 1, 2018
| let accumulated = ''; | ||
| gatherStderr.on('data', common.mustCallAtLeast((chunk) => { | ||
| accumulated += chunk; | ||
| // console.log(chunk); |
lib/internal/fs/watchers.js
Outdated
| @@ -161,7 +162,9 @@ FSWatcher.prototype.start = function(filename, | |||
| const error = errors.uvException({ | |||
| errno: err, | |||
| syscall: 'watch', | |||
| path: filename | |||
| path: filename, | |||
| description: err === UV_ENOSPC ? | |||
There was a problem hiding this comment.
Nit: Might want to call it message?
There was a problem hiding this comment.
+1 to call it message. By the way if the key is message it currently will not appear in the final error object as an additional property whereas description will.
|
Ping again @addaleax |
Providing `No space left on device` is misleading in this case. Replace it with something that describes it more accurately. Refs: https://stackoverflow.com/questions/22475849/node-js-error-enospc/32600959
addaleax
force-pushed
the
fs-watch-enospc
branch
from
b156539 to
310fdd4
Compare
addaleax
added
the
author ready
|
Rebased, with comments addressed. |
BridgeAR
approved these changes
Sep 16, 2018
thefourtheye
approved these changes
Sep 17, 2018
|
Landed in 13245dc |
addaleax
added a commit
that referenced
this pull request
Sep 22, 2018
Providing `No space left on device` is misleading in this case. Replace it with something that describes it more accurately. Refs: https://stackoverflow.com/questions/22475849/node-js-error-enospc/32600959 PR-URL: #21846 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 23, 2018
Providing `No space left on device` is misleading in this case. Replace it with something that describes it more accurately. Refs: https://stackoverflow.com/questions/22475849/node-js-error-enospc/32600959 PR-URL: #21846 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing
No space left on deviceis misleading in this case.Replace it with something that describes it more accurately.
Refs: https://stackoverflow.com/questions/22475849/node-js-error-enospc/32600959
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes