-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: remove arrays benchmark #21831
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
Issues and PRs related to the benchmark subsystem.
test
Issues and PRs related to the tests.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Jul 16, 2018
apapirovski
approved these changes
Jul 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's much point to these anymore.
BridgeAR
approved these changes
Jul 16, 2018
Trott
approved these changes
Jul 16, 2018
lpinca
approved these changes
Jul 17, 2018
hashseed
approved these changes
Jul 17, 2018
jasnell
approved these changes
Jul 17, 2018
trivikr
approved these changes
Jul 18, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 18, 2018
PR-URL: nodejs#21831 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Landed in 6dbaea7 |
targos
pushed a commit
that referenced
this pull request
Jul 19, 2018
PR-URL: #21831 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
This was referenced Aug 1, 2018
kkty
added a commit
to kkty/node
that referenced
this pull request
Jan 6, 2019
Benchmark for arrays no longer exists, but it was still referenced in documentation. Refs: nodejs#21831
addaleax
pushed a commit
that referenced
this pull request
Jan 9, 2019
Benchmark for arrays no longer exists, but it was still referenced in documentation. Refs: #21831 PR-URL: #25367 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jan 9, 2019
Benchmark for arrays no longer exists, but it was still referenced in documentation. Refs: #21831 PR-URL: #25367 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Benchmark for arrays no longer exists, but it was still referenced in documentation. Refs: nodejs#21831 PR-URL: nodejs#25367 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2019
Benchmark for arrays no longer exists, but it was still referenced in documentation. Refs: #21831 PR-URL: #25367 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
Benchmark for arrays no longer exists, but it was still referenced in documentation. Refs: #21831 PR-URL: #25367 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
Benchmark for arrays no longer exists, but it was still referenced in documentation. Refs: #21831 PR-URL: #25367 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesI'd like to suggest removing these benchmarks - here's a few reasons why:
Buffer
, which is interesting to benchmark from a Node point of view, but has it's own benchmark suite underbenchmarks/buffer
, so there is no need to duplicate it here.