Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce ESLint exceptions in benchmarks #21030

Closed
wants to merge 8 commits into from
Closed

reduce ESLint exceptions in benchmarks #21030

wants to merge 8 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 30, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Trott added 8 commits May 30, 2018 03:32
@Trott
benchmark: refactor deepequal-buffer
60a24f5 
This is a minor refactor of benchmark/assert/deepequal-buffer.js to
reduce exceptions that need to be made for lint compliance.
@Trott
benchmark: refactor deepequal-map
cacb155 
This is a minor refactor of benchmark/assert/deepequal-map.js to
reduce exceptions that need to be made for lint compliance.
@Trott
benchmark: refactor deepequal-object
e76f5c1 
This is a minor refactor of benchmark/assert/deepequal-object.js to
reduce exceptions that need to be made for lint compliance.
@Trott
benchmark: refactor prims-and-objs-big-array-set
b728cf5 
This is a minor refactor of
benchmark/assert/deepequal-prims-and-objs-big-array-set.js to
reduce exceptions that need to be made for lint compliance.
@Trott
benchmark: refactor prims-and-objs-big-loop
19189fb 
This is a minor refactor of
benchmark/assert/deepequal-prims-and-objs-big-loop.js to
reduce exceptions that need to be made for lint compliance.
@Trott
benchmark: refactor deepequal-set
05c542c 
This is a minor refactor of benchmark/assert/deepequal-set.js to
reduce exceptions that need to be made for lint compliance.
@Trott
benchmark: refactor deepequal-typedarrays
0bc8145 
This is a minor refactor of benchmark/assert/deepequal-typedarrays.js to
reduce exceptions that need to be made for lint compliance.
@Trott
benchmark: refactor benchmark/assert/throws.js
ab97403 
This is a minor refactor of benchmark/assert/throws.js to
reduce exceptions that need to be made for lint compliance.
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels May 30, 2018
@Trott
Copy link
Member Author

Trott commented May 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15162/

@nodejs nodejs deleted a comment from refack Jun 1, 2018
@Trott
Copy link
Member Author

Trott commented Jun 1, 2018

Re-running two unrelated CI failures:

https://ci.nodejs.org/job/node-test-commit-osx/19012/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/18457/

@Trott
Copy link
Member Author

Trott commented Jun 2, 2018

Windows re-run again: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18459/

@Trott
Copy link
Member Author

Trott commented Jun 2, 2018

Windows re-run with a rebase against master: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18462/

Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2018
@Trott
benchmark: refactor deepequal-buffer
206b19c 
This is a minor refactor of benchmark/assert/deepequal-buffer.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: nodejs#21030
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2018
@Trott
benchmark: refactor deepequal-map
1000c78 
This is a minor refactor of benchmark/assert/deepequal-map.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: nodejs#21030
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2018
@Trott
benchmark: refactor deepequal-object
07d3c55 
This is a minor refactor of benchmark/assert/deepequal-object.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: nodejs#21030
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2018
@Trott
benchmark: refactor prims-and-objs-big-array-set
7bfc00d 
This is a minor refactor of
benchmark/assert/deepequal-prims-and-objs-big-array-set.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: nodejs#21030
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2018
@Trott
benchmark: refactor prims-and-objs-big-loop
30650a6 
This is a minor refactor of
benchmark/assert/deepequal-prims-and-objs-big-loop.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: nodejs#21030
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2018
@Trott
benchmark: refactor deepequal-set
9cd4a23 
This is a minor refactor of benchmark/assert/deepequal-set.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: nodejs#21030
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2018
@Trott
benchmark: refactor deepequal-typedarrays
b8f8ca5 
This is a minor refactor of benchmark/assert/deepequal-typedarrays.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: nodejs#21030
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2018
@Trott
benchmark: refactor benchmark/assert/throws.js
f86e5fc 
This is a minor refactor of benchmark/assert/throws.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: nodejs#21030
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 2, 2018

Landed in Landed in 6168959...f86e5fc

@Trott Trott closed this Jun 2, 2018
@Trott Trott deleted the keflavik-3 branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @lpinca @targos @trivikr @nodejs-github-bot