test: fix flaky test-domain-timers #21019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for this test to be extremely infrequently flaky if 1ms or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail.
BridgeAR
approved these changes
May 29, 2018
trivikr
approved these changes
May 29, 2018
jasnell
approved these changes
May 29, 2018
starkwang
approved these changes
May 30, 2018
danbev
approved these changes
May 30, 2018
Trott
added
the
author ready
|
Re-running osx: https://ci.nodejs.org/job/node-test-commit-osx/18958/ |
|
Landed in 4b8ff3a |
apapirovski
added a commit
that referenced
this pull request
Jun 1, 2018
It's possible for this test to be extremely infrequently flaky if 1ms or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail. PR-URL: #21019 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 1, 2018
It's possible for this test to be extremely infrequently flaky if 1ms or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail. PR-URL: #21019 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for this test to be (extremely infrequently) flaky if 1ms (which due to rounding in libuv could be far less, actually) or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail.
This failed recently in https://ci.nodejs.org/job/node-test-commit-linuxone/1701/nodes=rhel72-s390x/testReport/junit/(root)/test/parallel_test_domain_timers/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes