Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: do not rely on the 'agentRemove' event #20786

Closed
wants to merge 1 commit into from
Closed

http: do not rely on the 'agentRemove' event #20786

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 16, 2018

Do not use the 'agentRemove' event to null socket._httpMessage as
that event is public and can be used to not keep a request in the agent.

Fixes: #20690

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@lpinca
http: do not rely on the 'agentRemove' event
560bbf4 
Do not use the `'agentRemove'` event to null `socket._httpMessage` as
that event is public and can be used to not keep a request in the agent.

Fixes: nodejs#20690
@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 16, 2018
@lpinca
Copy link
Member Author

lpinca commented May 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14912/

@BridgeAR BridgeAR requested review from apapirovski and jasnell May 18, 2018 00:04
@apapirovski
Copy link
Member

Landed in 4a940aa

apapirovski pushed a commit that referenced this pull request May 22, 2018
@lpinca @apapirovski
http: do not rely on the 'agentRemove' event
4a940aa 
Do not use the `'agentRemove'` event to null `socket._httpMessage` as
that event is public and can be used to not keep a request in the agent.

PR-URL: #20786
Fixes: #20690
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@lpinca lpinca deleted the gh-20690 branch May 22, 2018 08:14
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@lpinca @MylesBorins
http: do not rely on the 'agentRemove' event
3c05b03 
Do not use the `'agentRemove'` event to null `socket._httpMessage` as
that event is public and can be used to not keep a request in the agent.

PR-URL: #20786
Fixes: #20690
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 23, 2018
@lpinca @MylesBorins
http: do not rely on the 'agentRemove' event
75e4415 
Do not use the `'agentRemove'` event to null `socket._httpMessage` as
that event is public and can be used to not keep a request in the agent.

PR-URL: #20786
Fixes: #20690
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@lpinca lpinca mentioned this pull request Jul 8, 2018
Merged
@MylesBorins
Copy link
Contributor

hey @lpinca would you be able to manually backport to 8.x? 6.x is in maintenance mode, so unless this qualifies as an experience breaking bug it isn't likely to land as a fix

@lpinca
Copy link
Member Author

lpinca commented Jul 10, 2018

@MylesBorins yes, will do. For 6.x see #20690 (comment) not sure if that qualifies as qualifies as an "experience breaking bug".

@lpinca lpinca mentioned this pull request Jul 10, 2018
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
@lpinca @MylesBorins
http: do not rely on the 'agentRemove' event
52cc2d2 
Do not use the `'agentRemove'` event to null `socket._httpMessage` as
that event is public and can be used to not keep a request in the agent.

Backport-PR-URL: #20786
PR-URL: #20786
Fixes: #20690
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@lpinca @rvagg
http: do not rely on the 'agentRemove' event
1fc00f0 
Do not use the `'agentRemove'` event to null `socket._httpMessage` as
that event is public and can be used to not keep a request in the agent.

Backport-PR-URL: #20786
PR-URL: #20786
Fixes: #20690
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
@lpinca
http: do not rely on the 'agentRemove' event
11333c2 
Do not use the `'agentRemove'` event to null `socket._httpMessage` as
that event is public and can be used to not keep a request in the agent.

PR-URL: nodejs/node#20786
Fixes: nodejs/node#20690
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'emit' of null in _http_client.js
7 participants
@lpinca @apapirovski @MylesBorins @jasnell @BridgeAR @trivikr @nodejs-github-bot