Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix lint nits in COLLABORATOR_GUIDE.md #19762

Closed
wants to merge 1 commit into from
Closed

doc: fix lint nits in COLLABORATOR_GUIDE.md #19762

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Apr 2, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

To unbreak the doc linting)

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 2, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 2, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 2, 2018 •
edited
Loading

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/397/

@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 2, 2018
Closed
2 tasks
Trott
Trott approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on fast-tracking

@Trott
Copy link
Member

Trott commented Apr 2, 2018

@nodejs/collaborators A second approval and +1 for fast-tracking this would let us unbreak CI...

@jkrems
Copy link
Contributor

jkrems commented Apr 2, 2018

+1 for fast-tracking!

@vsemozhetbyt
Copy link
Contributor Author

Landing...

@vsemozhetbyt
Copy link
Contributor Author

Landed in 88773af. Thanks)

vsemozhetbyt added a commit that referenced this pull request Apr 2, 2018
@vsemozhetbyt
doc: fix lint nits in COLLABORATOR_GUIDE.md
88773af 
PR-URL: #19762
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
@vsemozhetbyt vsemozhetbyt deleted the doc-collaborator-guide branch April 2, 2018 23:19
targos pushed a commit that referenced this pull request Apr 3, 2018
@vsemozhetbyt @targos
doc: fix lint nits in COLLABORATOR_GUIDE.md
1aaad92 
PR-URL: #19762
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
@targos targos mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jkrems jkrems jkrems approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @Trott @jkrems @nodejs-github-bot