Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: don’t emit illegal utf-8 from icutrim/iculslocs #19756

Merged
merged 0 commits into from
Apr 3, 2018
Merged

tools: don’t emit illegal utf-8 from icutrim/iculslocs #19756

merged 0 commits into from
Apr 3, 2018

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 2, 2018

  • argv[0] was being emitted into a utf-8 stream, but argv[0] may
    not be legal utf-8
  • fix by not emitting argv[0] (was only for a source comment)

Fixes: #17077

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Apr 2, 2018
@srl295 srl295 self-assigned this Apr 2, 2018
@srl295 srl295 requested review from bnoordhuis and seishun April 2, 2018 17:22
@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Apr 2, 2018
seishun
seishun approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@seishun seishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if "Fixes: #17077" is correct since it's only one part of the problem.

@srl295
Copy link
Member Author

srl295 commented Apr 2, 2018 •
edited
Loading

@seishun does it fix #17077 but not #18560 ? Is there anything else that's not covered by #18560 and this PR that needs to be fixed?

I can drop the Fixes if you prefer, I guess it's a question about the scope of the two issues.

@seishun
Copy link
Contributor

seishun commented Apr 2, 2018

@srl295 it fixes neither. #17077 would still be an issue because of V8.

I don't know the rules about commits that fix one part of the problem.

@srl295
Copy link
Member Author

srl295 commented Apr 2, 2018

^ i'll re-open 17077 after this lands. Github doesn't understand the partially part of the commit message.

@seishun
Copy link
Contributor

seishun commented Apr 2, 2018

Seems reasonable to me.

@srl295
Copy link
Member Author

srl295 commented Apr 2, 2018 •
edited
Loading

node-test-linter:

16:42:56 stderr: fatal: Unable to create '/usr/home/iojs/build/workspace/node-test-linter/.git/index.lock': File exists.

cause: nodejs/build#1206 (comment)

@srl295 srl295 closed this Apr 3, 2018
@srl295 srl295 deleted the fix-iculslocs branch April 3, 2018 15:00
@srl295 srl295 merged commit a820f41 into nodejs:master Apr 3, 2018
targos pushed a commit that referenced this pull request Apr 3, 2018
@srl295 @targos
tools: don’t emit illegal utf-8 from icutrim/iculslocs
53d7fbb 
- argv[0] was being emitted into a utf-8 stream, but argv[0] may
not be legal utf-8
- fix by not emitting argv[0] (was only for a source comment)
- partially resolves #17077

PR-URL: #19756
Fixes: #17077
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Nikolai Vavilov <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 4, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@srl295 @MylesBorins
tools: don’t emit illegal utf-8 from icutrim/iculslocs
fc41817 
- argv[0] was being emitted into a utf-8 stream, but argv[0] may
not be legal utf-8
- fix by not emitting argv[0] (was only for a source comment)
- partially resolves #17077

PR-URL: #19756
Fixes: #17077
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Nikolai Vavilov <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seishun seishun seishun approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees

@srl295 srl295

Labels
i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate non-ASCII build file path on Windows
7 participants
@srl295 @seishun @bnoordhuis @jasnell @addaleax @MylesBorins @nodejs-github-bot