http: support server options on createServer #19461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Mar 19, 2018
|
I am not sure what failed here. I ran the tests locally and they passed, and that console output is a bit tough to decipher. Can someone point me to what is actually broken and where I can see the output? |
|
Are these the output from the actual failures? https://ci.nodejs.org/job/node-test-commit-plinux/nodes=ppcle-ubuntu1404/16151/console I don't see any directly actionable output, but I don't really know what I am looking for here. |
lpinca
approved these changes
Mar 20, 2018
lpinca
added
the
author ready
|
@wesleytodd failures are unrelated, don't worry about that. |
jasnell
approved these changes
Mar 20, 2018
|
Landed in 42d8ea0, thank you and congratulations on becoming a Node.js contributor! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Mar 25, 2018
PR-URL: #19461 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2018
PR-URL: #19461 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
removed
the
author ready
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe feature and docs were added in #15752, but it looks like the
http.createServercall was missed. I looked for someone else fixing this issue but did not find it.Also this is my first PR, and I tried to follow all the contribution instructions but I may have missed something, so any help with what else I am missing would be great. Thanks in advance.