Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make CI requirements more stringent in COLLABORATORS_GUIDE #19458

Closed
wants to merge 6 commits into from
Closed

doc: make CI requirements more stringent in COLLABORATORS_GUIDE #19458

wants to merge 6 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 19, 2018

Make CI requirements more stringent in COLLABORATORS_GUIDE.md. Also make name/email checking for commits reflect current practice and (regarding name) policy.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 19, 2018
@Trott Trott changed the title It's not easy bein' green doc: make CI requirements more stringent in COLLABORATORS_GUIDE Mar 19, 2018
@Trott
Copy link
Member Author

Trott commented Mar 19, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/269/

cjihrig
cjihrig approved these changes Mar 19, 2018
View reviewed changes
COLLABORATOR_GUIDE.md Outdated
status indicator.

Do not land any Pull Requests without passing (green or yellow) CI runs. If you
believe any failed (red or grey) Ci sub-tasks are unrelated to the change in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci -> CI

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2018
mhdawson
mhdawson approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Mar 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/281/

Trott added 6 commits March 21, 2018 16:37
@Trott
doc: reduce CI options in COLLABORATOR_GUIDE.md
ccb22c6
@Trott
doc: simplify COLLABORATOR_GUIDE.md instructions
87e59ba 
Remove bulleted list formatting. Only check email/name for new
contributors. Change `full name` to `name` and remove italics to avoid
incorrect implication that we need a "legal name".
@Trott
doc: require passing CI for landing code
2340a50
@Trott
squash
35e25fe
@Trott
squash
2d3047b
@Trott
squash
62eb03f
@Trott Trott force-pushed the it's-not-easy-bein'-green branch from a78fa42 to 62eb03f Compare March 21, 2018 23:38
@Trott
Copy link
Member Author

Trott commented Mar 21, 2018 •
edited
Loading

Rebased to resolve conflicts.

@Trott
Copy link
Member Author

Trott commented Mar 21, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/285/

@Trott
Copy link
Member Author

Trott commented Mar 21, 2018

Since commits have been force pushed (due to the needed rebase) since the last review, can I ask someone to take a quick look again?

maclover7
maclover7 approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WDYT about adding this as an announcement to the next TSC meeting?

@Trott
Copy link
Member Author

Trott commented Mar 22, 2018

LGTM. WDYT about adding this as an announcement to the next TSC meeting?

@maclover7 That's a good idea.

Trott added a commit to Trott/io.js that referenced this pull request Mar 22, 2018
@Trott
doc: reduce CI options in COLLABORATOR_GUIDE.md
f3e078f 
PR-URL: nodejs#19458
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 22, 2018
@Trott
doc: simplify COLLABORATOR_GUIDE.md instructions
a72bfb9 
Remove bulleted list formatting. Only check email/name for new
contributors. Change `full name` to `name` and remove italics to avoid
incorrect implication that we need a "legal name".

PR-URL: nodejs#19458
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 22, 2018
@Trott
doc: require passing CI for landing code
01b74d1 
PR-URL: nodejs#19458
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 22, 2018

Landed in 9b34ea6...01b74d1

@Trott Trott closed this Mar 22, 2018
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
targos pushed a commit that referenced this pull request Mar 24, 2018
@Trott @targos
doc: reduce CI options in COLLABORATOR_GUIDE.md
e5bcd8d 
PR-URL: #19458
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
targos pushed a commit that referenced this pull request Mar 24, 2018
@Trott @targos
doc: simplify COLLABORATOR_GUIDE.md instructions
98d038a 
Remove bulleted list formatting. Only check email/name for new
contributors. Change `full name` to `name` and remove italics to avoid
incorrect implication that we need a "legal name".

PR-URL: #19458
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
targos pushed a commit that referenced this pull request Mar 24, 2018
@Trott @targos
doc: require passing CI for landing code
65c9a52 
PR-URL: #19458
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@Trott Trott mentioned this pull request Jul 10, 2018
Closed
@Trott Trott deleted the it's-not-easy-bein'-green branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Trott @danbev @lpinca @targos @cjihrig @maclover7 @richardlau @mhdawson @tniessen @nodejs-github-bot