Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: delete test-regress-GH-4948 #19279

Closed
wants to merge 1 commit into from
Closed

test: delete test-regress-GH-4948 #19279

wants to merge 1 commit into from

Conversation

ryzokuken
Copy link
Contributor

@ryzokuken ryzokuken commented Mar 11, 2018 •
edited by lpinca
Loading

Refs: #19275 (comment)
Refs: #19275 (comment)

@lpinca here we go.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 11, 2018
@ryzokuken ryzokuken changed the title test: delete test/parallel/test-regress-GH-4948 test: delete test-regress-GH-4948 Mar 11, 2018
@lpinca
Copy link
Member

lpinca commented Mar 11, 2018

Little background here.
This test was introduced in https://github.com/nodejs/node-v0.x-archive/pull/4948/files. At that time IncomingMessage.prototype._dump() was setting this.socket.parser.incoming to null. This no longer happens so I think the test is useless as it's not testing anything.

lpinca
lpinca approved these changes Mar 11, 2018
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@lpinca
Copy link
Member

lpinca commented Mar 11, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13620/

@ryzokuken
Copy link
Contributor Author

@lpinca any idea why so many tests failed? I don't this should result in any test failure. Flaky tests?

@lpinca
Copy link
Member

lpinca commented Mar 11, 2018

Yes, failures seem unrelated. I don't see how removing a test make others fail.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2018
@lpinca
Copy link
Member

lpinca commented Mar 13, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/255/

@lpinca
Copy link
Member

lpinca commented Mar 13, 2018

Landed in 52e869b.

lpinca pushed a commit that referenced this pull request Mar 13, 2018
@ryzokuken @lpinca
test: delete test/parallel/test-regress-GH-4948
52e869b 
PR-URL: #19279
Refs: #19275 (comment)
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@lpinca lpinca closed this Mar 13, 2018
targos pushed a commit that referenced this pull request Mar 17, 2018
@ryzokuken @targos
test: delete test/parallel/test-regress-GH-4948
9a08f12 
PR-URL: #19279
Refs: #19275 (comment)
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@ryzokuken @MylesBorins
test: delete test/parallel/test-regress-GH-4948
11a0ef5 
PR-URL: #19279
Refs: #19275 (comment)
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@ryzokuken @MayaLekova
test: delete test/parallel/test-regress-GH-4948
bd5de01 
PR-URL: nodejs#19279
Refs: nodejs#19275 (comment)
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ryzokuken @lpinca @jasnell @gireeshpunathil @BridgeAR @BethGriggs @nodejs-github-bot