Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix assertion argument order #19264

Closed
wants to merge 1 commit into from
Closed

test: fix assertion argument order #19264

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 9, 2018

Fix the assertion argument order so that it will report "actual" and
"expected" correctly when the test fails.

Ref: #19263

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: fix assertion argument order
3841636 
Fix the assertion argument order so that it will report "actual" and
"expected" correctly when the test fails.

Ref: nodejs#19263
@Trott Trott added the test Issues and PRs related to the tests. label Mar 9, 2018
@Trott
Copy link
Member Author

Trott commented Mar 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13609/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2018
jasnell pushed a commit that referenced this pull request Mar 12, 2018
@Trott @jasnell
test: fix assertion argument order
da226ea 
Fix the assertion argument order so that it will report "actual" and
"expected" correctly when the test fails.

Ref: #19263

PR-URL: #19264
Refs: #19263
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 12, 2018

Landed in da226ea

@jasnell jasnell closed this Mar 12, 2018
targos pushed a commit that referenced this pull request Mar 17, 2018
@Trott @targos
test: fix assertion argument order
ed594f8 
Fix the assertion argument order so that it will report "actual" and
"expected" correctly when the test fails.

Ref: #19263

PR-URL: #19264
Refs: #19263
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@Trott @MylesBorins
test: fix assertion argument order
f84f548 
Fix the assertion argument order so that it will report "actual" and
"expected" correctly when the test fails.

Ref: #19263

PR-URL: #19264
Refs: #19263
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Trott @MayaLekova
test: fix assertion argument order
3f2d485 
Fix the assertion argument order so that it will report "actual" and
"expected" correctly when the test fails.

Ref: nodejs#19263

PR-URL: nodejs#19264
Refs: nodejs#19263
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 16, 2018
@Trott @BethGriggs
test: fix assertion argument order
4bcdc1b 
Fix the assertion argument order so that it will report "actual" and
"expected" correctly when the test fails.

Ref: #19263

PR-URL: #19264
Refs: #19263
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
@Trott Trott deleted the reverse-args branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @lpinca @cjihrig @tniessen @richardlau @BethGriggs