Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update arm minimum supported platform #19164

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Mar 6, 2018

This is already true in practice.

Fixes: nodejs/build#1164

cc/ @nodejs/build @rvagg @gdams

@rvagg I'm not sure if this applies to arm (not arm64) as well.

@gibfahn gibfahn self-assigned this Mar 6, 2018
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Mar 6, 2018
@rvagg
Copy link
Member

rvagg commented Mar 6, 2018

Correct for ARM64, not so much for other ARM. We test (and build) on Wheezy for ARMv6 and ARMv7, so that gives us glibc >= 2.13 for both of those. When you include kernel version things get even more complicated because the lowest we're running for ARMv7 is 3.2.34 but on ARMv6 we get 4.1.19 because we're using a Jessie boot setup to get the best out of our Pi's. I really don't know that we want to be that specific here.

I've argued against including kernel versions in here previously since it rarely matters when you account for libc and just makes things messy and complicated. I'm willing to bet that exactly zero people have found the kernel version we list helpful in any practical way.

@BridgeAR
Copy link
Member

BridgeAR commented Mar 6, 2018

I guess this list is actually difficult to properly maintain. Is there any way we could automate something that produces a list of supported systems and their minimum build versions?

@rvagg
Copy link
Member

rvagg commented Mar 7, 2018

@BridgeAR I guess an Ansible script or two to run across all our release- machines would get a pretty good picture? While we're at it the same thing could be run across all of test- to get a snapshot of what's actually in use.

@gibfahn
Copy link
Member Author

gibfahn commented Mar 7, 2018

I guess an Ansible script or two to run across all our release- machines would get a pretty good picture? While we're at it the same thing could be run across all of test- to get a snapshot of what's actually in use.

I think test- is probably more valuable than release- right? We don't actually check that node runs on the machines we build it on.

I guess in some cases we might have "experimental" or Tier 2 platforms that we build for but don't run CI on?

@gibfahn
Copy link
Member Author

gibfahn commented Mar 7, 2018

@rvagg I'm not sure if this applies to arm (not arm64) as well.

Correct for ARM64, not so much for other ARM.

Yeah, I figured that.

My vote would be for switching to a set of "these are the platforms we build and test on", but it seems wrong to leave the arm reference wrong. So how about I leave ARM as it was, and just change ARM64?

@rvagg
Copy link
Member

rvagg commented Mar 8, 2018

yeah, put a lid back on that can of worms

@gibfahn
Copy link
Member Author

gibfahn commented Mar 9, 2018

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gibfahn
Copy link
Member Author

gibfahn commented Mar 9, 2018

This is already true in practice.

PR-URL: nodejs#19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@gibfahn gibfahn merged commit 099e621 into nodejs:master Mar 9, 2018
@gibfahn gibfahn deleted the arm-libc branch March 9, 2018 17:27
targos pushed a commit that referenced this pull request Mar 17, 2018
This is already true in practice.

PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
This is already true in practice.

PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This is already true in practice.

PR-URL: nodejs#19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 17, 2018

should this be backported to 8.x? If so, a separate backport PR is needed.

BethGriggs pushed a commit that referenced this pull request Oct 30, 2018
This is already true in practice.

Backport-PR-URL: #23275
PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glibc version on arm64
7 participants