-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update arm minimum supported platform #19164
Conversation
Correct for ARM64, not so much for other ARM. We test (and build) on Wheezy for ARMv6 and ARMv7, so that gives us I've argued against including kernel versions in here previously since it rarely matters when you account for libc and just makes things messy and complicated. I'm willing to bet that exactly zero people have found the kernel version we list helpful in any practical way. |
I guess this list is actually difficult to properly maintain. Is there any way we could automate something that produces a list of supported systems and their minimum build versions? |
@BridgeAR I guess an Ansible script or two to run across all our release- machines would get a pretty good picture? While we're at it the same thing could be run across all of test- to get a snapshot of what's actually in use. |
I think I guess in some cases we might have "experimental" or Tier 2 platforms that we build for but don't run CI on? |
Yeah, I figured that. My vote would be for switching to a set of "these are the platforms we build and test on", but it seems wrong to leave the arm reference wrong. So how about I leave ARM as it was, and just change ARM64? |
yeah, put a lid back on that can of worms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is already true in practice. PR-URL: nodejs#19164 Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This is already true in practice. PR-URL: #19164 Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This is already true in practice. PR-URL: #19164 Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This is already true in practice. PR-URL: nodejs#19164 Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
should this be backported to 8.x? If so, a separate backport PR is needed. |
This is already true in practice. Backport-PR-URL: #23275 PR-URL: #19164 Fixes: nodejs/build#1164 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This is already true in practice.
Fixes: nodejs/build#1164
cc/ @nodejs/build @rvagg @gdams
@rvagg I'm not sure if this applies to
arm
(notarm64
) as well.