tools: new eslint rules #18831

BridgeAR · 2018-02-17T03:48:05Z

This introduces a few more eslint rules for things that the code base already handles well but that we some times still have to point out in PRs.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

tools, doc, util, benchmark, test

lpinca · 2018-02-17T12:36:33Z

doc/api/stream.md

@@ -1842,7 +1842,7 @@ class Counter extends Readable {
    if (i > this._max)
      this.push(null);
    else {
-      const str = '' + i;
+      const str = `${i}`;


Nit: String(i)?

BridgeAR · 2018-02-17T13:15:06Z

CI https://ci.nodejs.org/job/node-test-pull-request/13239/

This also fixes the three entries that did not pass.

The former notation was deprecated. This updates it as recommended.

BridgeAR · 2018-02-22T14:21:50Z

Rebased due to conflicts (the eslint file changed, that is it).

Light-CI https://ci.nodejs.org/job/node-test-commit-light/309/

This also fixes the three entries that did not pass. PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The former notation was deprecated. This updates it as recommended. PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

BridgeAR · 2018-02-22T14:57:46Z

Landed in a926c1a...d6fc7e3

MylesBorins · 2018-03-06T21:28:09Z

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BridgeAR · 2018-03-10T00:34:57Z

Backported in #19244

This also fixes the three entries that did not pass. PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This also fixes the three entries that did not pass. Backport-PR-URL: #19244 PR-URL: #18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Backport-PR-URL: #19244 PR-URL: #18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This also fixes the three entries that did not pass. PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The former notation was deprecated. This updates it as recommended. PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: nodejs#18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

MylesBorins · 2018-07-31T18:41:00Z

Backport requested for 8.x in #19244

nodejs-github-bot added tools Issues and PRs related to the tools directory. util Issues and PRs related to the built-in util module. labels Feb 17, 2018

lpinca approved these changes Feb 17, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2018

mmarchini approved these changes Feb 17, 2018

View reviewed changes

addaleax approved these changes Feb 17, 2018

View reviewed changes

targos approved these changes Feb 17, 2018

View reviewed changes

apapirovski approved these changes Feb 17, 2018

View reviewed changes

cjihrig approved these changes Feb 18, 2018

View reviewed changes

BridgeAR added 6 commits February 22, 2018 14:16

tools: enable eslint no-undef-init rule

eb26998

This also fixes the three entries that did not pass.

tools: enable eslint strict key-spacing

8583f20

tools: enable eslint no-whitespace-before-property rule

b2def4e

tools: enable eslint one-var rule

38ebc0a

tools: update eslint rule

da0707f

The former notation was deprecated. This updates it as recommended.

doc: enable eslint prefer-template rule

9be8798

BridgeAR force-pushed the new-rules branch from 186a002 to 9be8798 Compare February 22, 2018 14:20

BridgeAR closed this Feb 22, 2018

MylesBorins added the backport-requested-v9.x label Mar 6, 2018

BridgeAR mentioned this pull request Mar 8, 2018

[v9.x backport] This is backporting multiple commits that were requested #19244

Closed

4 tasks

MylesBorins added backported-to-v9.x and removed backport-requested-v9.x labels Mar 21, 2018

targos mentioned this pull request Mar 21, 2018

v9.9.0 proposal #19428

Merged

MylesBorins added the backport-requested-v8.x label Jul 31, 2018

BridgeAR deleted the new-rules branch April 1, 2019 23:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: new eslint rules #18831

tools: new eslint rules #18831

BridgeAR commented Feb 17, 2018

lpinca Feb 17, 2018

BridgeAR commented Feb 17, 2018

BridgeAR commented Feb 22, 2018

BridgeAR commented Feb 22, 2018

MylesBorins commented Mar 6, 2018

BridgeAR commented Mar 10, 2018

MylesBorins commented Jul 31, 2018

tools: new eslint rules #18831

tools: new eslint rules #18831

Conversation

BridgeAR commented Feb 17, 2018

Checklist

Affected core subsystem(s)

lpinca Feb 17, 2018

Choose a reason for hiding this comment

BridgeAR commented Feb 17, 2018

BridgeAR commented Feb 22, 2018

BridgeAR commented Feb 22, 2018

MylesBorins commented Mar 6, 2018

BridgeAR commented Mar 10, 2018

MylesBorins commented Jul 31, 2018