module: fix main lookup regression from #18728 #18788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
added
the
esm
nodejs-github-bot
added
the
c++
guybedford
force-pushed
the
main-lookup-regression
branch
from
b419326 to
3e9066c
Compare
benjamingr
approved these changes
Feb 15, 2018
benjamingr
added
fast-track
|
Also, that's weird @guybedford - it shouldn't be possible as far as I know :O http://coliru.stacked-crooked.com/a/efc7c335a197e56d |
|
@guybedford What was the regression? |
|
@jdalton the process of applying the package.json @benjamingr that is really odd then that there was not even a compiler warning, and seems like it could be a problem! Since we don't have compiler warnings for these cases, do you think I should just extend bool for these enums and switch their parity so they can be treated as booleans without breaking? Just thinking of maintainability here. |
jasnell
approved these changes
Feb 16, 2018
|
Landed in 7748865 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 16, 2018
PR-URL: nodejs#18788 Refs: nodejs#18728 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
|
this should be backported with #18728 |
2 tasks
guybedford
added a commit
to guybedford/node
that referenced
this pull request
Mar 4, 2018
PR-URL: nodejs#18788 Refs: nodejs#18728 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2018
Backport-PR-URL: #18923 PR-URL: #18788 Refs: #18728 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18788 Refs: nodejs#18728 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a minor regression in #18728 in the package.json main resolution code path.
This includes a test and a fix, hopefully these sort of slips will become harder as the test coverage on the modules work increases.
@bnoordhuis one of the slips here was on the enum booleans being checked as booleans. I considered making them extend boolean, but I assumed the intention is that usage should always be explicit with these, although it's a shame this can't be caught by the compiler at all.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
modules