-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of test-tls-over-http-tunnel #18784
Refactor of test-tls-over-http-tunnel #18784
Conversation
@@ -24,6 +24,9 @@ const common = require('../common'); | |||
if (!common.hasCrypto) | |||
common.skip('missing crypto'); | |||
|
|||
// This test ensures that the data throught tls over http tunnel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: throught
-> through
Also, probably data received through
rather than just data through
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes made. Thank you @Trott for feedback
PR-URL: nodejs#18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Landed in 2960096 🎉 @juggernaut451 I fixed the commit message while landing. Please check our commit guidelines briefly. They are always included as default text when opening a PR. Those checkboxes should actually also be checked accordingly :-) |
@BridgeAR will read it and will keep check from next time. |
PR-URL: #18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
PR-URL: #18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
PR-URL: nodejs#18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
PR-URL: #18784 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test
Changes that are done in file are :
#14544