build: include the libuv and zlib into node #18383

yhwang · 2018-01-25T19:53:08Z

Add libuv and zlib into node executable and shared lib. Also fix an
issue that openssl is not fully included in node executable for macOS.

fixes #17444

Signed-off-by: Yihong Wang [email protected]

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build

addaleax

LGTM if CI is happy:

CI: https://ci.nodejs.org/job/node-test-commit/15690/

yhwang · 2018-01-26T01:12:32Z

This test case failed on Windows: parallel/test-tls-server-verify. I saw someone is fixing it now. Not related to my change.

bnoordhuis · 2018-01-26T10:59:14Z

node.gypi

+            },
+          },
+          'conditions': [
+            ['OS in "linux freebsd openbsd solaris android" and '


ldflags applies only to platforms that aren't Windows or MacOS so this is better written as OS != "aix", which I think the intent was? Likewise on line 165.

yes and changed.

bnoordhuis · 2018-01-26T11:02:18Z

node.gypi

              'conditions': [
                ['OS in "linux freebsd" and node_shared=="false"', {
                  'ldflags': [
                    '-Wl,--whole-archive,'
-                        '<(OBJ_DIR)/deps/openssl/'
-                        '<(OPENSSL_PRODUCT)',
+                    '<(OBJ_DIR)/deps/openssl/<(OPENSSL_PRODUCT)',


Can you indent here? It's a line (and string) continuation.

good catch and done

yhwang · 2018-01-26T19:02:33Z

updated the change based on @bnoordhuis comments

bnoordhuis

Thanks, LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/12804/

yhwang · 2018-01-29T18:39:32Z

Looks like the error of AIX shows up in other PR. is the AIX env for CI broken?

bnoordhuis · 2018-01-29T21:26:13Z

Infrastructure issue. Let's try it one more time for good luck: https://ci.nodejs.org/job/node-test-commit/15775/

There's also this but I can't say if it's caused by this PR:

Building addon /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/addons-napi/test_make_callback/
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | linux | x64
gyp info chdir /home/iojs/build/workspace/node-test-commit-linux/nodes/debian8-64/test/addons/heap-profiler/
Aborted
Makefile:326: recipe for target 'test/addons/.buildstamp' failed
make[1]: *** [test/addons/.buildstamp] Error 1

bnoordhuis · 2018-01-30T00:40:58Z

Not a happy run either... the alpine buildbot failure is most likely a flaky test but I don't immediately see why the linuxone run failed and the aix buildbot still has infrastructure issues.

cc @nodejs/build - known issue?

yhwang · 2018-01-30T01:19:49Z

the weird thing is I can't tell the root cause from the console log (the linuxone)

mhdawson

LGTM

mhdawson · 2018-01-31T18:39:48Z

Another CI run: https://ci.nodejs.org/job/node-test-pull-request/12853/

mhdawson · 2018-01-31T20:48:31Z

This is another CI run, https://ci.nodejs.org/job/node-test-commit/15831/

mhdawson · 2018-01-31T20:51:57Z

In the last CI run there were failures on debian, but this unrelated PR has the excact same failures: https://ci.nodejs.org/job/node-test-commit-linux/15991/nodes=debian8-64/console. That and the fact that some earlier CI runs for this PR did not have failures on debian mean that I believe the CI run is good.

BridgeAR · 2018-02-01T12:21:08Z

@yhwang would you be so kind and rebase? :-)

yhwang · 2018-02-01T18:12:37Z

@BridgeAR thanks for the reminding. rebase is done. Please kick off a CI.

Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Fixes: nodejs#17444 Signed-off-by: Yihong Wang <[email protected]>

mhdawson · 2018-02-01T19:41:16Z

CI run: https://ci.nodejs.org/job/node-test-pull-request/12897/

yhwang · 2018-02-01T22:38:17Z

one failure: test-http-pipeline-flood. It's a flaky test case.

addaleax · 2018-02-04T15:45:29Z

Landed in d161625

Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Signed-off-by: Yihong Wang <[email protected]> Fixes: #17444 PR-URL: #18383 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>

MylesBorins · 2018-02-20T23:48:10Z

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Signed-off-by: Yihong Wang <[email protected]> Fixes: nodejs#17444 PR-URL: nodejs#18383 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>

Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Signed-off-by: Yihong Wang <[email protected]> Fixes: #17444 PR-URL: #18383 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>

Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Signed-off-by: Yihong Wang <[email protected]> Fixes: nodejs#17444 PR-URL: nodejs#18383 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>

addaleax · 2018-06-29T22:31:53Z

I’ve landed this as 4f21b66 in v8.x-staging because, as I understand it, it applies there as well – let me know if that was a mistake.

Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Signed-off-by: Yihong Wang <[email protected]> Fixes: #17444 PR-URL: #18383 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 25, 2018

addaleax approved these changes Jan 25, 2018

View reviewed changes

yhwang changed the title ~~Include the libuv and zlib into node~~ build: include the libuv and zlib into node Jan 26, 2018

gireeshpunathil approved these changes Jan 26, 2018

View reviewed changes

bnoordhuis reviewed Jan 26, 2018

View reviewed changes

yhwang force-pushed the whole-archive-libuv branch from a95449d to 44dbb2d Compare January 26, 2018 19:00

maclover7 force-pushed the master branch from bb5575a to 993b716 Compare January 26, 2018 22:03

cjihrig force-pushed the master branch from 993b716 to 082f952 Compare January 26, 2018 22:36

bnoordhuis approved these changes Jan 29, 2018

View reviewed changes

bnoordhuis added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2018

mhdawson approved these changes Jan 31, 2018

View reviewed changes

jasnell approved these changes Jan 31, 2018

View reviewed changes

BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2018

yhwang force-pushed the whole-archive-libuv branch from 44dbb2d to cae3458 Compare February 1, 2018 17:34

yhwang force-pushed the whole-archive-libuv branch from cae3458 to 90d5c48 Compare February 1, 2018 18:18

build: include the libuv and zlib into node

3a24b71

Add libuv and zlib into node executable and shared lib. Also fix an issue that openssl is not fully included in node executable for macOS. Fixes: nodejs#17444 Signed-off-by: Yihong Wang <[email protected]>

yhwang force-pushed the whole-archive-libuv branch from 90d5c48 to 3a24b71 Compare February 1, 2018 18:20

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2018

addaleax closed this Feb 4, 2018

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018

yhwang deleted the whole-archive-libuv branch February 5, 2018 17:26

MylesBorins added the backport-requested-v9.x label Feb 20, 2018

yhwang mentioned this pull request Feb 21, 2018

[v9.x backport] build: include the libuv and zlib into node #18912

Closed

2 tasks

addaleax removed the backport-requested-v9.x label Feb 26, 2018

addaleax mentioned this pull request Feb 27, 2018

v9.7.0 proposal #19040

Closed

addaleax added the land-on-v8.x label Jun 29, 2018

MylesBorins mentioned this pull request Jul 9, 2018

v8.12.0 proposal #21593

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: include the libuv and zlib into node #18383

build: include the libuv and zlib into node #18383

yhwang commented Jan 25, 2018

addaleax left a comment

yhwang commented Jan 26, 2018

bnoordhuis Jan 26, 2018

yhwang Jan 26, 2018

bnoordhuis Jan 26, 2018

yhwang Jan 26, 2018

yhwang commented Jan 26, 2018

bnoordhuis left a comment

yhwang commented Jan 29, 2018

bnoordhuis commented Jan 29, 2018

bnoordhuis commented Jan 30, 2018

yhwang commented Jan 30, 2018 •

edited

Loading

mhdawson left a comment

mhdawson commented Jan 31, 2018

mhdawson commented Jan 31, 2018

mhdawson commented Jan 31, 2018

BridgeAR commented Feb 1, 2018

yhwang commented Feb 1, 2018

mhdawson commented Feb 1, 2018

yhwang commented Feb 1, 2018

addaleax commented Feb 4, 2018

MylesBorins commented Feb 20, 2018

addaleax commented Jun 29, 2018

build: include the libuv and zlib into node #18383

build: include the libuv and zlib into node #18383

Conversation

yhwang commented Jan 25, 2018

Checklist

Affected core subsystem(s)

addaleax left a comment

Choose a reason for hiding this comment

yhwang commented Jan 26, 2018

bnoordhuis Jan 26, 2018

Choose a reason for hiding this comment

yhwang Jan 26, 2018

Choose a reason for hiding this comment

bnoordhuis Jan 26, 2018

Choose a reason for hiding this comment

yhwang Jan 26, 2018

Choose a reason for hiding this comment

yhwang commented Jan 26, 2018

bnoordhuis left a comment

Choose a reason for hiding this comment

yhwang commented Jan 29, 2018

bnoordhuis commented Jan 29, 2018

bnoordhuis commented Jan 30, 2018

yhwang commented Jan 30, 2018 • edited Loading

mhdawson left a comment

Choose a reason for hiding this comment

mhdawson commented Jan 31, 2018

mhdawson commented Jan 31, 2018

mhdawson commented Jan 31, 2018

BridgeAR commented Feb 1, 2018

yhwang commented Feb 1, 2018

mhdawson commented Feb 1, 2018

yhwang commented Feb 1, 2018

addaleax commented Feb 4, 2018

MylesBorins commented Feb 20, 2018

addaleax commented Jun 29, 2018

yhwang commented Jan 30, 2018 •

edited

Loading