test: make test-async-wrap-getasyncid parallelizable #18245
Conversation
|
stress test: https://ci.nodejs.org/job/node-stress-single-test/1720/ (expect to fail until #18241 lands, but should fail with the flake instead of EACCES) |
|
(Ah, wait, the title is actually misleading, it should be "make test-async-wrap-getasyncid runnable by itself" but that's probably too long.. |
|
The stress test is actually green. I tried it on my local alpine box and I think the flake cannot be reproduced by simply stressing this test... |
|
Oh, I tried a different configuration and this time the flake shows up: https://ci.nodejs.org/job/node-stress-single-test/1721/nodes=alpine34-container-x64/ |
joyeecheung
force-pushed
the
fix-awg-test
branch
from
bf543f8 to
97561c9
Compare
|
Went with @Trott 's suggestion and put the CI: https://ci.nodejs.org/job/node-test-pull-request/12617/ |
|
@nodejs/collaborators Does anyone oppose having this fast-tracked? I would like to land this relatively soon and then run the stress test against #18241 |
apapirovski
added
the
fast-track
|
+1 to fast-tracking. |
|
Thanks everyone. Landed in bfe41fe |
PR-URL: #18245 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18245 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18245 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #18245 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#18245 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Previously this test cannot be run with the node-stress-single-test job because the tmp dir is not created before
common.PIPEis listened. See https://ci.nodejs.org/job/node-stress-single-test/1712/nodes=alpine34-container-x64/consoleChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test