Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in TextEncoding section #18201

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in TextEncoding section #18201

wants to merge 1 commit into from

Conversation

yosuke-furukawa
Copy link
Member

I just found a typo in TextEncoding section to gather util api docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Jan 17, 2018
@starkwang starkwang added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 17, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2018
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/90/

@benjamingr
Copy link
Member

@vsemozhetbyt I've missed the memo - what's test-pull-request-lite 😮 ?

@vsemozhetbyt
Copy link
Contributor

It is a linter test + linuxone job including doc building, if I get it right — so this is a handy minimum for just doc PRs.

@benjamingr
Copy link
Member

@vsemozhetbyt very nice!

@benjamingr
Copy link
Member

CI looks green, going to land this to demonstrate the Node.js process in 2 hours to non-core people if you don't mind (if anyone feels strongly feel free to land before).

@benjamingr
Copy link
Member

Landed in 98f744c

@benjamingr benjamingr closed this Jan 17, 2018
benjamingr pushed a commit that referenced this pull request Jan 17, 2018
@yosuke-furukawa
doc: fix typo in TextEncoding section
98f744c 
PR-URL: #18201
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@yosuke-furukawa @evanlucas
doc: fix typo in TextEncoding section
2fb5f19 
PR-URL: #18201
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@yosuke-furukawa @MylesBorins
doc: fix typo in TextEncoding section
f7b48a3 
PR-URL: #18201
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@richardlau richardlau richardlau approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.