-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: simplify sentences that use "considered" #18095
Conversation
Change many instances of "x is considered to be y" to "x is y".
@@ -622,7 +622,7 @@ Once a socket is assigned to this request and is connected | |||
added: v0.5.9 | |||
--> | |||
|
|||
* `timeout` {number} Milliseconds before a request is considered to be timed out. | |||
* `timeout` {number} Milliseconds before a request times out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but I think this description is a bit misleading. This timeout expires only after x
millisecond of inactivity on the socket. It's possible that a data chunk resets the timeout right before it expires without completing the request.
I'll open a separate PR if I remember :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lpinca Perhaps you or I can add a squash-able commit here to change it to Milliseconds of inactivity before a request times out.
?
Landed in c6bee70. |
Change many instances of "x is considered to be y" to "x is y". PR-URL: nodejs#18095 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Change many instances of "x is considered to be y" to "x is y". PR-URL: #18095 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Change many instances of "x is considered to be y" to "x is y". PR-URL: #18095 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Change many instances of "x is considered to be y" to "x is y". PR-URL: #18095 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Change many instances of "x is considered to be y" to "x is y". PR-URL: nodejs#18095 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Change many instances of "x is considered to be y" to "x is y".
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc