Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify sentences that use "considered" #18095

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 11, 2018

Change many instances of "x is considered to be y" to "x is y".

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Change many instances of "x is considered to be y" to "x is y".
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 11, 2018
@Trott
Copy link
Member Author

Trott commented Jan 11, 2018

@@ -622,7 +622,7 @@ Once a socket is assigned to this request and is connected
added: v0.5.9
-->

* `timeout` {number} Milliseconds before a request is considered to be timed out.
* `timeout` {number} Milliseconds before a request times out.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but I think this description is a bit misleading. This timeout expires only after x millisecond of inactivity on the socket. It's possible that a data chunk resets the timeout right before it expires without completing the request.

I'll open a separate PR if I remember :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpinca Perhaps you or I can add a squash-able commit here to change it to Milliseconds of inactivity before a request times out.?

@Trott
Copy link
Member Author

Trott commented Jan 18, 2018

Landed in c6bee70.

@Trott Trott closed this Jan 18, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jan 18, 2018
Change many instances of "x is considered to be y" to "x is y".

PR-URL: nodejs#18095
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
Change many instances of "x is considered to be y" to "x is y".

PR-URL: #18095
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
Change many instances of "x is considered to be y" to "x is y".

PR-URL: #18095
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
Change many instances of "x is considered to be y" to "x is y".

PR-URL: #18095
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Feb 27, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Change many instances of "x is considered to be y" to "x is y".

PR-URL: nodejs#18095
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott deleted the consider-the-lobster branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants