tls: fix SNICallback without .server option #17835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`options.server` only needs to be set when its contents are actually being inspected.
TimothyGu
approved these changes
Dec 23, 2017
lpinca
approved these changes
Dec 23, 2017
| new tls.TLSSocket(serverSide, { | ||
| isServer: true, | ||
| SNICallback: common.mustCall((servername, cb) => { | ||
| assert.strictEqual('www.google.com', servername); |
There was a problem hiding this comment.
Nit: can you please swap the args?
cjihrig
approved these changes
Dec 24, 2017
jasnell
approved these changes
Dec 27, 2017
addaleax
added
the
author ready
addaleax
added a commit
that referenced
this pull request
Dec 27, 2017
`options.server` only needs to be set when its contents are actually being inspected. PR-URL: #17835 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 46510f5 |
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
`options.server` only needs to be set when its contents are actually being inspected. PR-URL: #17835 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
`options.server` only needs to be set when its contents are actually being inspected. PR-URL: #17835 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
`options.server` only needs to be set when its contents are actually being inspected. PR-URL: #17835 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
|
This has test failures on 6.x and 8.x, @addaleax would you be willing to backport? I assume it's a simple fix. === release test-tls-socket-snicallback-without-server ===
Path: parallel/test-tls-socket-snicallback-without-server
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
at Object.exports.mustCall (/Users/gib/wrk/com/DANGER/node/test/common/index.js:499:10)
at Object.<anonymous> (/Users/gib/wrk/com/DANGER/node/test/parallel/test-tls-socket-snicallback-without-server.js:18:23)
at Module._compile (module.js:643:30)
at Object.Module._extensions..js (module.js:654:10)
at Module.load (module.js:556:32)
at tryModuleLoad (module.js:499:12)
at Function.Module._load (module.js:491:3)
at Function.Module.runMain (module.js:684:10)
at startup (bootstrap_node.js:188:16)
Command: out/Release/node /Users/gib/wrk/com/DANGER/node/test/parallel/test-tls-socket-snicallback-without-server.js
[00:00|% 100|+ 0|- 1]: Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.serveronly needs to be set when its contents are actually being inspected.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tls