Fix AttributeError: __exit__ on Python 2.6 #17663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error occurs while dealing with Tar archives
|
cc @srl295 |
addaleax
approved these changes
Dec 13, 2017
addaleax
added
i18n-api
jasnell
approved these changes
Dec 14, 2017
srl295
approved these changes
Dec 14, 2017
addaleax
added
the
author ready
|
@srl295 Is there a specific reason you assigned yourself for this? Should we wait for sth from you? I don't think there's anything standing in the way of landing this PR at this point... |
jasnell
approved these changes
Dec 27, 2017
cjihrig
approved these changes
Dec 27, 2017
|
Landed in b0dd43c |
addaleax
removed
the
author ready
addaleax
pushed a commit
that referenced
this pull request
Dec 27, 2017
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
Error occurs while dealing with Tar archives PR-URL: #17663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error occurs while dealing with Tar archives
To reproduce run
./configure --with-intl=full-icu --with-icu-source=icu4c-60_1-src.tgzChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes