-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix link for https api change #17630
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
https
Issues or PRs related to the https subsystem.
labels
Dec 12, 2017
The PR number included for this api addition was originally incorrect. Refs: nodejs#14903
MylesBorins
force-pushed
the
fix-link
branch
from
December 12, 2017 09:23
59867ed
to
2627f85
Compare
vsemozhetbyt
approved these changes
Dec 12, 2017
vsemozhetbyt
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Dec 12, 2017
evanlucas
approved these changes
Dec 12, 2017
cjihrig
approved these changes
Dec 12, 2017
maclover7
approved these changes
Dec 12, 2017
mhdawson
approved these changes
Dec 12, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Trott
approved these changes
Dec 12, 2017
maclover7
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 12, 2017
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Dec 12, 2017
The PR number included for this api addition was originally incorrect. PR-URL: nodejs#17630 Refs: nodejs#14903 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Landed in dc92540 BTW: I fixed the subsystem to "doc" 😉 |
addaleax
removed
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 13, 2017
MylesBorins
added a commit
that referenced
this pull request
Jan 10, 2018
The PR number included for this api addition was originally incorrect. PR-URL: #17630 Refs: #14903 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins
added a commit
that referenced
this pull request
Jan 10, 2018
The PR number included for this api addition was originally incorrect. PR-URL: #17630 Refs: #14903 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
https
Issues or PRs related to the https subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR number included for this api addition was originally incorrect.
Refs: #14903