util: Speed up the common case of formatting a single string. #1749

ChALkeR · 2015-05-20T19:29:31Z

This slightly speeds up a common case of formatting a single string.
Used, for example, by console.log("string").

Fishrock123 · 2015-05-20T20:12:54Z

lib/util.js

@@ -13,6 +13,8 @@ exports.format = function(f) {
    return objects.join(' ');
  }

+  if (arguments.length === 1) return f;
+
  var i = 1;
  var args = arguments;


It would probably also help to not leak the arguments here.

Maybe consider https://gist.github.com/Fishrock123/98c35a0c745cb59d7496

Fishrock123 · 2015-05-20T20:13:38Z

👍

bnoordhuis · 2015-05-20T20:20:09Z

LGTM

ChALkeR · 2015-05-20T20:38:45Z

for (var i = 0; i < 10000000; i++) {
    util.format('abcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabc1234567890');
}

Before: 4.3 seconds, 2323414 ops/sec.
After: 0.63 seconds, 15927170 ops/sec.

ChALkeR · 2015-05-20T20:40:43Z

With cloning arguments — 0.29 seconds, 34269599 ops/sec.

ChALkeR · 2015-05-20T20:41:59Z

~~Should I add the arguments cloning to this PR or make a separate one?~~
I do not want to add arguments cloning to this PR to keep it simple. Let's make a separate one regarding arguments.

Fishrock123 · 2015-05-20T20:50:57Z

~~I think this isn't quite right, you still need it to run though https://github.com/nodejs/io.js/blob/master/lib/util.js#L36-L42 afaik.~~

Nope, I'm wrong. LGTM

ChALkeR · 2015-05-20T21:19:38Z

For

for (var i = 0; i < 1000000; i++) {
    console.log('abcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabcabc1234567890');
}

There is about 35% speedup.

PR-URL: #1749 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

bnoordhuis · 2015-05-20T21:35:02Z

Landed in 214d020.

PR-URL: nodejs#1749 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

PR-URL: nodejs#1532 Notable Changes: * crypto: Diffie-Hellman key exchange (DHE) parameters ('dhparams') must now be 1024 bits or longer or an error will be thrown. A warning will also be printed to the console if you supply less than 2048 bits. See https://weakdh.org/ for further context on this security concern. (Shigeki Ohtsu) nodejs#1739. * node: A new --trace-sync-io command line flag will print a warning and a stack trace whenever a synchronous API is used. This can be used to track down synchronous calls that may be slowing down an application. (Trevor Norris) nodejs#1707. * node: To allow for chaining of methods, the setTimeout(), setKeepAlive(), setNoDelay(), ref() and unref() methods used in 'net', 'dgram', 'http', 'https' and 'tls' now return the current instance instead of undefined (Roman Reiss) nodejs#1779. * util: A significant speed-up (in the order of 35%) for the common-case of a single string argument to util.format(), used by console.log() (Сковорода Никита Андреевич) nodejs#1749.

PR-URL: nodejs#1532 Notable Changes: * crypto: Diffie-Hellman key exchange (DHE) parameters ('dhparams') must now be 1024 bits or longer or an error will be thrown. A warning will also be printed to the console if you supply less than 2048 bits. See https://weakdh.org/ for further context on this security concern. (Shigeki Ohtsu) nodejs#1739. * node: A new --trace-sync-io command line flag will print a warning and a stack trace whenever a synchronous API is used. This can be used to track down synchronous calls that may be slowing down an application. (Trevor Norris) nodejs#1707. * node: To allow for chaining of methods, the setTimeout(), setKeepAlive(), setNoDelay(), ref() and unref() methods used in 'net', 'dgram', 'http', 'https' and 'tls' now return the current instance instead of undefined (Roman Reiss & Evan Lucas) nodejs#1699 nodejs#1768 nodejs#1779. * util: A significant speed-up (in the order of 35%) for the common-case of a single string argument to util.format(), used by console.log() (Сковорода Никита Андреевич) nodejs#1749.

PR-URL: nodejs#1532 Notable Changes: * crypto: Diffie-Hellman key exchange (DHE) parameters ('dhparams') must now be 1024 bits or longer or an error will be thrown. A warning will also be printed to the console if you supply less than 2048 bits. See https://weakdh.org/ for further context on this security concern. (Shigeki Ohtsu) nodejs#1739. * node: A new --trace-sync-io command line flag will print a warning and a stack trace whenever a synchronous API is used. This can be used to track down synchronous calls that may be slowing down an application. (Trevor Norris) nodejs#1707. * node: To allow for chaining of methods, the setTimeout(), setKeepAlive(), setNoDelay(), ref() and unref() methods used in 'net', 'dgram', 'http', 'https' and 'tls' now return the current instance instead of undefined (Roman Reiss & Evan Lucas) nodejs#1699 nodejs#1768 nodejs#1779. * npm: Upgraded to v2.10.1, release notes can be found in https://github.com/npm/npm/releases/tag/v2.10.1 and https://github.com/npm/npm/releases/tag/v2.10.0. * util: A significant speed-up (in the order of 35%) for the common-case of a single string argument to util.format(), used by console.log() (Сковорода Никита Андреевич) nodejs#1749.

PR-URL: #1777 Notable Changes: * crypto: Diffie-Hellman key exchange (DHE) parameters ('dhparams') must now be 1024 bits or longer or an error will be thrown. A warning will also be printed to the console if you supply less than 2048 bits. See https://weakdh.org/ for further context on this security concern. (Shigeki Ohtsu) #1739. * node: A new --trace-sync-io command line flag will print a warning and a stack trace whenever a synchronous API is used. This can be used to track down synchronous calls that may be slowing down an application. (Trevor Norris) #1707. * node: To allow for chaining of methods, the setTimeout(), setKeepAlive(), setNoDelay(), ref() and unref() methods used in 'net', 'dgram', 'http', 'https' and 'tls' now return the current instance instead of undefined (Roman Reiss & Evan Lucas) #1699 #1768 #1779. * npm: Upgraded to v2.10.1, release notes can be found in https://github.com/npm/npm/releases/tag/v2.10.1 and https://github.com/npm/npm/releases/tag/v2.10.0. * util: A significant speed-up (in the order of 35%) for the common-case of a single string argument to util.format(), used by console.log() (Сковорода Никита Андреевич) #1749.

PR-URL: nodejs/node#1749 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

util: Speed up the common case of formatting a single string.

76e326c

mscdex added the util Issues and PRs related to the built-in util module. label May 20, 2015

ChALkeR mentioned this pull request May 20, 2015

Why does node/io.js hang when printing to the console inside a loop? #1741

Closed

Fishrock123 reviewed May 20, 2015
View reviewed changes

bnoordhuis pushed a commit that referenced this pull request May 20, 2015

util: speed up common case of formatting string

214d020

PR-URL: #1749 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

bnoordhuis closed this May 20, 2015

ChALkeR deleted the util-format-singlestring branch May 20, 2015 21:39

ChALkeR mentioned this pull request May 20, 2015

lib: Prevent leaking arguments in several places. #1752

Closed

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 21, 2015

util: speed up common case of formatting string

0c6a548

PR-URL: nodejs#1749 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

rvagg mentioned this pull request May 23, 2015

Release proposal v2.1.0 #1777

Closed

andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015

util: speed up common case of formatting string

499ef38

PR-URL: nodejs/node#1749 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

ChALkeR added the performance Issues and PRs related to the performance of Node.js. label Feb 16, 2016

estliberitas mentioned this pull request Feb 17, 2016

util: possible way to speed up util.format() #5285

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: Speed up the common case of formatting a single string. #1749

util: Speed up the common case of formatting a single string. #1749

ChALkeR commented May 20, 2015

Fishrock123 May 20, 2015

Fishrock123 commented May 20, 2015

bnoordhuis commented May 20, 2015

ChALkeR commented May 20, 2015

ChALkeR commented May 20, 2015

ChALkeR commented May 20, 2015

Fishrock123 commented May 20, 2015

ChALkeR commented May 20, 2015

bnoordhuis commented May 20, 2015

util: Speed up the common case of formatting a single string. #1749

util: Speed up the common case of formatting a single string. #1749

Conversation

ChALkeR commented May 20, 2015

Fishrock123 May 20, 2015

Choose a reason for hiding this comment

Fishrock123 commented May 20, 2015

bnoordhuis commented May 20, 2015

ChALkeR commented May 20, 2015

ChALkeR commented May 20, 2015

ChALkeR commented May 20, 2015

Fishrock123 commented May 20, 2015

ChALkeR commented May 20, 2015

bnoordhuis commented May 20, 2015