test: fix flaky test-benchmark-util #17473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for zero iterations on benchmarks with a short duration.
Trott
added
benchmark
|
Example failure without this change: https://ci.nodejs.org/job/node-test-commit-linux/14693/nodes=alpine36-container-x64/consoleFull not ok 157 parallel/test-benchmark-util
---
duration_ms: 4.604
severity: fail
stack: |-
util/format.js
util/format.js type="" n=1: 2,443.7927663734113
util/inspect-array.js
util/inspect-array.js type="" len=100000 n=1: 13.369450815581954
util/inspect-proxy.js
util/inspect-proxy.js n=1: 493.1190172335234
util/inspect.js
util/inspect.js option="none" method="Array" n=1: 44.57330487832981
util/normalize-encoding.js
/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine36-container-x64/benchmark/common.js:202
throw new Error('insufficient clock precision for short benchmark');
^
Error: insufficient clock precision for short benchmark
at Benchmark.end (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine36-container-x64/benchmark/common.js:202:13)
at main (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine36-container-x64/benchmark/util/normalize-encoding.js:63:9)
at Benchmark.process.nextTick (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine36-container-x64/benchmark/common.js:34:28)
at process._tickCallback (internal/process/next_tick.js:155:11)
at Function.Module.runMain (module.js:703:11)
at startup (bootstrap_node.js:195:16)
at bootstrap_node.js:646:3
assert.js:42
throw new errors.AssertionError({
^
AssertionError [ERR_ASSERTION]: 1 strictEqual 0
at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine36-container-x64/test/common/benchmark.js:25:12)
at ChildProcess.emit (events.js:126:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12) |
jasnell
approved these changes
Dec 5, 2017
cjihrig
approved these changes
Dec 5, 2017
|
plinux failure on CI has to be unrelated but just in case: https://ci.nodejs.org/job/node-test-commit-plinux/13703/ Same for LinuxOne: https://ci.nodejs.org/job/node-test-commit-linuxone/10887/ |
|
(CI is good.) |
XadillaX
approved these changes
Dec 6, 2017
|
Landed in 6c0c60c |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 7, 2017
Allow for zero iterations on benchmarks with a short duration. PR-URL: nodejs#17473 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Allow for zero iterations on benchmarks with a short duration. PR-URL: #17473 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Allow for zero iterations on benchmarks with a short duration. PR-URL: #17473 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for zero iterations on benchmarks with a short duration.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark util