-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test-benchmark-dgram #17462
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add settings to test-benchmark-dgram such that it only runs benchmark per benchmark file.
Trott
added
benchmark
Issues and PRs related to the benchmark subsystem.
dgram
Issues and PRs related to the dgram subsystem / UDP.
test
Issues and PRs related to the tests.
labels
Dec 5, 2017
Trott
force-pushed
the
test-bench-dgram
branch
from
December 5, 2017 01:00
a948ee1
to
52f2487
Compare
cjihrig
approved these changes
Dec 5, 2017
jasnell
approved these changes
Dec 5, 2017
BridgeAR
approved these changes
Dec 6, 2017
This does not require 48 hours out of my perspective |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 6, 2017
PR-URL: nodejs#17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 6, 2017
Add settings to test-benchmark-dgram such that it only runs benchmark per benchmark file. PR-URL: nodejs#17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Add settings to test-benchmark-dgram such that it only runs benchmark per benchmark file. PR-URL: #17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Add settings to test-benchmark-dgram such that it only runs benchmark per benchmark file. PR-URL: #17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Add settings to test-benchmark-dgram such that it only runs benchmark per benchmark file. PR-URL: #17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Add settings to test-benchmark-dgram such that it only runs benchmark per benchmark file. PR-URL: #17462 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #16113. (/cc @jopann)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test benchmark dgram