Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix typo in NODE_OPTIONS whitelist #17369

Closed
wants to merge 1 commit into from
Closed

src: fix typo in NODE_OPTIONS whitelist #17369

wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@evanlucas
src: fix typo in NODE_OPTIONS whitelist
1218263 
The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 28, 2017
@addaleax addaleax added trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. lts-watch-v8.x labels Nov 28, 2017
@evanlucas
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11776/

mhdawson
mhdawson approved these changes Nov 28, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2017
@evanlucas
Copy link
Contributor Author

Thanks landing now!

@evanlucas evanlucas closed this Nov 30, 2017
evanlucas added a commit to evanlucas/node that referenced this pull request Nov 30, 2017
@evanlucas
src: fix typo in NODE_OPTIONS whitelist
701dc9a 
The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.

PR-URL: nodejs#17369
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas
Copy link
Contributor Author

Landed in 701dc9a. Thanks!

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@evanlucas @MylesBorins
src: fix typo in NODE_OPTIONS whitelist
b3ca6a3 
The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.

PR-URL: #17369
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@evanlucas @MylesBorins
src: fix typo in NODE_OPTIONS whitelist
7f55f98 
The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.

PR-URL: #17369
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@evanlucas @gibfahn
src: fix typo in NODE_OPTIONS whitelist
ecb78e6 
The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.

PR-URL: #17369
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@evanlucas @gibfahn
src: fix typo in NODE_OPTIONS whitelist
3c8bdd9 
The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.

PR-URL: #17369
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@evanlucas @addaleax @cjihrig @maclover7 @richardlau @mhdawson @gibfahn @nodejs-github-bot