update : test-http-upgrade-client to use countdown
#17339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxlab
suggested changes
Nov 27, 2017
| @@ -60,7 +61,8 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() { | |||
| ['Origin', 'http://www.websocket.org'] | |||
| ] | |||
| ]; | |||
| let left = headers.length; | |||
| const countdown = new Countdown(10, () => srv.close()); | |||
There was a problem hiding this comment.
Why 10 ? It should be headers.length.
There was a problem hiding this comment.
@daxlab : My bad.. thanks much for the correction. I've updated the PR. Kindly review!
daxlab
approved these changes
Nov 27, 2017
mithunsasidharan
changed the title
test-http-upgrade-client to use countdowntest-http-upgrade-client to use countdown
maclover7
approved these changes
Nov 27, 2017
|
@apapirovski : Can you please run the CI for this too ? |
|
Same here, CI is green too. Should be ready to land when someone gets a moment. |
apapirovski
approved these changes
Dec 3, 2017
|
Landing... |
|
Thank you for your contribution, landed in eb19c6b. |
maclover7
pushed a commit
that referenced
this pull request
Dec 3, 2017
PR-URL: #17339 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17339 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17339 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17339 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17339 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17339 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the test case
test-http-upgrade-clientto use countdown, as per issue #17169Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test