test: Update test-http-parser-free to use countdown timer #17322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxlab
force-pushed
the
test-http-parser-free
branch
from
db88f70 to
ad7608f
Compare
maclover7
approved these changes
Nov 26, 2017
| if (++responses === N) { | ||
| server.close(); | ||
| } | ||
| countdown.dec(); | ||
| res.resume(); | ||
| }); | ||
| })(i); | ||
| } | ||
| }); | ||
|
|
||
| process.on('exit', function() { |
There was a problem hiding this comment.
Do we still need this check? Doesn't server.close() / end of execution from the Countdown mean we've already hit zero remaining?
cc @jasnell
There was a problem hiding this comment.
Yep, the process.on('exit') can be removed.
jasnell
approved these changes
Nov 26, 2017
Done. |
addaleax
approved these changes
Nov 27, 2017
addaleax
added
the
author ready
|
Landed in 6d1f8a3 |
addaleax
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17169
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)