Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make use of Number.isNaN to test-readfloat.js #17310

Closed
wants to merge 1 commit into from
Closed

test: make use of Number.isNaN to test-readfloat.js #17310

wants to merge 1 commit into from

Conversation

hiromoon
Copy link
Contributor

@hiromoon hiromoon commented Nov 26, 2017 •
edited
Loading

This is part of Nodefest's Code and Learn nodejs/code-and-learn#72

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@joyeecheung joyeecheung added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 26, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11718/

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Nov 26, 2017
jasnell pushed a commit that referenced this pull request Nov 26, 2017
@hiromoon @jasnell
test: make use of Number.isNaN to test-readfloat.js
ff59fd7 
PR-URL: #17310
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 26, 2017

Landed in ff59fd7. Thank you and congrats on your PR to core!

@jasnell jasnell closed this Nov 26, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@hiromoon @MylesBorins
test: make use of Number.isNaN to test-readfloat.js
b085fc9 
PR-URL: #17310
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@hiromoon @MylesBorins
test: make use of Number.isNaN to test-readfloat.js
91e2117 
PR-URL: #17310
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@hiromoon @gibfahn
test: make use of Number.isNaN to test-readfloat.js
cdab6ea 
PR-URL: #17310
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@hiromoon @gibfahn
test: make use of Number.isNaN to test-readfloat.js
32ebcf7 
PR-URL: #17310
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@hiromoon @gibfahn
test: make use of Number.isNaN to test-readfloat.js
7f4aafc 
PR-URL: #17310
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@maclover7 maclover7 maclover7 approved these changes

@targos targos targos approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.