Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: vcbuild refactoring #17299

Merged
merged 1 commit into from
Dec 2, 2017
Merged

build: vcbuild refactoring #17299

merged 1 commit into from
Dec 2, 2017

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 25, 2017

  • More consistent compilation of arguments to ./configure
  • Code indent
  • Call to explicit .exe binary
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build,windows

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Nov 25, 2017
@refack
Copy link
Contributor Author

refack commented Nov 25, 2017

CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/13780/

@refack
Copy link
Contributor Author

refack commented Nov 25, 2017

/CC @nodejs/build @nodejs/platform-windows

tniessen
tniessen approved these changes Dec 2, 2017
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, did you test all options (just to be sure)?

@refack
Copy link
Contributor Author

refack commented Dec 2, 2017

I tested this by mocking configure to simply print the args and exit(1). Made sure the calls are the same.

@refack refack force-pushed the vcbuild-refactoring branch from 400f69a to 9fb390a Compare December 2, 2017 23:02
@refack refack merged commit 9fb390a into nodejs:master Dec 2, 2017
@refack refack deleted the vcbuild-refactoring branch December 5, 2017 13:53
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@refack @MylesBorins
build,win: vcbuild refactoring call configure
9e9af6e 
PR-URL: #17299
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@refack @MylesBorins
build,win: vcbuild refactoring call configure
90a5e9f 
PR-URL: #17299
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@refack @gibfahn
build,win: vcbuild refactoring call configure
80abd64 
PR-URL: #17299
Reviewed-By: Tobias Nießen <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@refack @gibfahn
build,win: vcbuild refactoring call configure
811892e 
PR-URL: #17299
Reviewed-By: Tobias Nießen <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@rvagg rvagg mentioned this pull request Jan 8, 2018
Closed
rvagg added a commit to rvagg/io.js that referenced this pull request Jan 9, 2018
@rvagg
build,win: restore vcbuild TAG functionality
c1b106a 
--tag needs to be set after `getnodeversion` because TAG is defined in
there when DISTTYPE is not "release", setting it before `getnodeversion`
leads to --tag not being passed down in to `configure` and
src/node_version.h setting it as `-pre` by default. This change restores
the functionality that properly sets the TAG for nightlies, rc builds
and other custom build types.

Ref: nodejs#17299
Ref: nodejs/abi-stable-node#289
mhdawson pushed a commit that referenced this pull request Jan 11, 2018
@rvagg @mhdawson
build,win: restore vcbuild TAG functionality
b225970 
--tag needs to be set after `getnodeversion` because TAG is defined in
there when DISTTYPE is not "release", setting it before `getnodeversion`
leads to --tag not being passed down in to `configure` and
src/node_version.h setting it as `-pre` by default. This change restores
the functionality that properly sets the TAG for nightlies, rc builds
and other custom build types.

Ref: #17299
Ref: nodejs/abi-stable-node#289

PR-URL: #18031
Ref: #17299
Ref: nodejs/abi-stable-node#289
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: JoãReis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
kfarnung pushed a commit to kfarnung/node-chakracore that referenced this pull request Jan 11, 2018
@rvagg @kfarnung
build,win: restore vcbuild TAG functionality
560b195 
--tag needs to be set after `getnodeversion` because TAG is defined in
there when DISTTYPE is not "release", setting it before `getnodeversion`
leads to --tag not being passed down in to `configure` and
src/node_version.h setting it as `-pre` by default. This change restores
the functionality that properly sets the TAG for nightlies, rc builds
and other custom build types.

Ref: nodejs/node#17299
Ref: nodejs/abi-stable-node#289

PR-URL: nodejs/node#18031
Ref: nodejs/node#17299
Ref: nodejs/abi-stable-node#289
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: JoãReis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
@kfarnung kfarnung mentioned this pull request Jan 12, 2018
Merged
2 tasks
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@rvagg @evanlucas
build,win: restore vcbuild TAG functionality
d8ac817 
--tag needs to be set after `getnodeversion` because TAG is defined in
there when DISTTYPE is not "release", setting it before `getnodeversion`
leads to --tag not being passed down in to `configure` and
src/node_version.h setting it as `-pre` by default. This change restores
the functionality that properly sets the TAG for nightlies, rc builds
and other custom build types.

Ref: #17299
Ref: nodejs/abi-stable-node#289

PR-URL: #18031
Ref: #17299
Ref: nodejs/abi-stable-node#289
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: JoãReis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@rvagg @MylesBorins
build,win: restore vcbuild TAG functionality
674e75d 
--tag needs to be set after `getnodeversion` because TAG is defined in
there when DISTTYPE is not "release", setting it before `getnodeversion`
leads to --tag not being passed down in to `configure` and
src/node_version.h setting it as `-pre` by default. This change restores
the functionality that properly sets the TAG for nightlies, rc builds
and other custom build types.

Ref: #17299
Ref: nodejs/abi-stable-node#289

PR-URL: #18031
Ref: #17299
Ref: nodejs/abi-stable-node#289
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: JoãReis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@rvagg @MylesBorins
build,win: restore vcbuild TAG functionality
ab4809f 
--tag needs to be set after `getnodeversion` because TAG is defined in
there when DISTTYPE is not "release", setting it before `getnodeversion`
leads to --tag not being passed down in to `configure` and
src/node_version.h setting it as `-pre` by default. This change restores
the functionality that properly sets the TAG for nightlies, rc builds
and other custom build types.

Ref: #17299
Ref: nodejs/abi-stable-node#289

PR-URL: #18031
Ref: #17299
Ref: nodejs/abi-stable-node#289
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: JoãReis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Kyle Farnung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refack @tniessen @gibfahn @nodejs-github-bot