build: fix test-v8 target #17269
build: fix test-v8 target #17269
Conversation
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: nodejs#14901 Fixes: nodejs/node-v8#26
nodejs-github-bot
added
the
build
|
I already tested this on my v8-6.3 branch: https://ci.nodejs.org/job/node-test-commit-v8-linux/1071/ |
| @@ -501,6 +501,7 @@ test-v8: v8 | |||
| --no-presubmit \ | |||
| --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \ | |||
| $(TAP_V8) | |||
| git clean -fdxq -- deps/v8 | |||
There was a problem hiding this comment.
Can we assume the presence of git, i.e. is this target valid for running from the source tarball?
There was a problem hiding this comment.
This target depends on the v8 target, which executes make-v8.sh, which already assumes the presence of git.
There was a problem hiding this comment.
But maybe replace x with X?
If I'm understanding git's logic, it'll use node's .git not deps/v8/.git
There was a problem hiding this comment.
deps/v8/.git is removed in make-v8.sh during cleanup:
Line 16 in 088bba3
There was a problem hiding this comment.
So definatly -X (it will remove explicitly ignored files, while keeping newly added files)
|
Test failure is unrelated. See #17270 |
|
I want to propose reverting #14901 for now. |
|
I see no harm in this change even after 088bba3. |
|
landed in 6c47033 |
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Clean the deps/v8 directory before rebuilding node for the hash seed
test. It is necessary to avoid the script added in 1 to use ignored
files while generating
node-debug-support.cc.Fixes: nodejs/node-v8#26
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @bnoordhuis @mmarchini