Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove empty VCLibrarianTool entry #17191

Closed
wants to merge 1 commit into from
Closed

build: remove empty VCLibrarianTool entry #17191

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 21, 2017

I've come across this empty entry a few times and tried building and running the tests on windows successfully. Wanted to bring this is up in case it was just overlooked.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build, win

cc @nodejs/build @nodejs/platform-windows

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 21, 2017
@refack
Copy link
Contributor

refack commented Nov 21, 2017

I always assumed it was left there as a hint that configuring LIB is possible via GYP (since it's not mentioned in the docs) 🤷‍♂️

@mscdex mscdex added the windows Issues and PRs related to the Windows platform. label Nov 21, 2017
@bzoz
Copy link
Contributor

bzoz commented Nov 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11657/

@gibfahn
Copy link
Member

gibfahn commented Nov 23, 2017

I always assumed it was left there as a hint that configuring LIB is possible via GYP (since it's not mentioned in the docs) 🤷‍♂️

Maybe replace with a comment that says that explicitly?

@danbev
Copy link
Contributor Author

danbev commented Nov 23, 2017

I always assumed it was left there as a hint that configuring LIB is possible via GYP (since it's not mentioned in the docs)

There is another usage here and I was thinking that it would be enough as reference.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2017
@danbev
Copy link
Contributor Author

danbev commented Nov 27, 2017

Landed in e308142

@danbev danbev closed this Nov 27, 2017
danbev added a commit that referenced this pull request Nov 27, 2017
@danbev
build: remove empty VCLibrarianTool entry
e308142 
PR-URL: #17191
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danbev danbev deleted the remove-empty-vslibrariantool branch November 27, 2017 06:26
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
build: remove empty VCLibrarianTool entry
20c1b28 
PR-URL: #17191
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
build: remove empty VCLibrarianTool entry
e05d1ec 
PR-URL: #17191
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
build: remove empty VCLibrarianTool entry
0f727c0 
PR-URL: #17191
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@danbev @gibfahn
build: remove empty VCLibrarianTool entry
c2e3a10 
PR-URL: #17191
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@danbev @gibfahn
build: remove empty VCLibrarianTool entry
9ba35e8 
PR-URL: #17191
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@danbev @gibfahn
build: remove empty VCLibrarianTool entry
bacbdc9 
PR-URL: #17191
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzoz bzoz bzoz approved these changes

@gibfahn gibfahn gibfahn approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@danbev @refack @bzoz @gibfahn @jasnell @addaleax @mscdex @nodejs-github-bot