src: fix bad sizeof expression #17014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
fhinkel
approved these changes
Nov 14, 2017
gireeshpunathil
approved these changes
Nov 14, 2017
danbev
approved these changes
Nov 14, 2017
refack
approved these changes
Nov 14, 2017
cjihrig
approved these changes
Nov 14, 2017
jasnell
approved these changes
Nov 14, 2017
addaleax
approved these changes
Nov 14, 2017
tniessen
approved these changes
Nov 15, 2017
It was computing the size of the pointer, not the size of the pointed-to object. Introduced in commit 727b291 ("src,dns: refactor cares_wrap to avoid global state".) PR-URL: nodejs#17014 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
bnoordhuis
force-pushed
the
fix-cares-sizeof
branch
from
4c054aa to
8203ce8
Compare
|
I've landed this in 8203ce8 in < 48 hours because it's an out and out bug, not much discussion possible (but plenty of sign-offs, for that matter.) |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 11, 2017
It was computing the size of the pointer, not the size of the pointed-to object. Introduced in commit 727b291 ("src,dns: refactor cares_wrap to avoid global state".) PR-URL: #17014 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
4 tasks
|
Fix for #14518, so should land with that on v6.x (if it goes back). |
gibfahn
pushed a commit
that referenced
this pull request
Dec 13, 2017
It was computing the size of the pointer, not the size of the pointed-to object. Introduced in commit 727b291 ("src,dns: refactor cares_wrap to avoid global state".) PR-URL: #17014 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was computing the size of the pointer, not the size of the pointed-to
object.
Introduced in commit 727b291 ("src,dns: refactor cares_wrap to avoid
global state".)
CI: https://ci.nodejs.org/job/node-test-pull-request/11416/(jenkins issue)CI: https://ci.nodejs.org/job/node-test-pull-request/11418/